Skip to content

Commit 723d2f4

Browse files
committed
Use NDK 24.0.8215888
This needs to be forced in a few places otherwise the build tries to pull in ndk 23
1 parent 65ee814 commit 723d2f4

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

Diff for: ReactAndroid/build.gradle

+1-3
Original file line numberDiff line numberDiff line change
@@ -528,9 +528,7 @@ android {
528528
if (rootProject.hasProperty("ndkPath")) {
529529
ndkPath rootProject.ext.ndkPath
530530
}
531-
if (rootProject.hasProperty("ndkVersion")) {
532-
ndkVersion rootProject.ext.ndkVersion
533-
}
531+
ndkVersion = "24.0.8215888"
534532

535533
defaultConfig {
536534
minSdkVersion(21)

Diff for: ReactAndroid/hermes-engine/build.gradle

+1-3
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,7 @@ android {
159159
if (rootProject.hasProperty("ndkPath")) {
160160
ndkPath rootProject.ext.ndkPath
161161
}
162-
if (rootProject.hasProperty("ndkVersion")) {
163-
ndkVersion rootProject.ext.ndkVersion
164-
}
162+
ndkVersion = "24.0.8215888"
165163

166164
defaultConfig {
167165
minSdkVersion 21

Diff for: packages/rn-tester/android/app/build.gradle

+2-4
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,8 @@ android {
9898
if (rootProject.hasProperty("ndkPath")) {
9999
ndkPath rootProject.ext.ndkPath
100100
}
101-
if (rootProject.hasProperty("ndkVersion")) {
102-
ndkVersion rootProject.ext.ndkVersion
103-
}
104-
101+
ndkVersion = "24.0.8215888"
102+
105103
flavorDimensions "vm"
106104
productFlavors {
107105
hermes {

Diff for: template/android/build.gradle

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ buildscript {
77
compileSdkVersion = 33
88
targetSdkVersion = 33
99

10-
// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
11-
ndkVersion = "23.1.7779620"
10+
ndkVersion = "24.0.8215888"
1211
}
1312
repositories {
1413
google()

0 commit comments

Comments
 (0)