Skip to content

Commit 99f71c5

Browse files
committed
Fix failing tests
1 parent 2c6b804 commit 99f71c5

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

launcher_go/v2/cli_build_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,10 @@ var _ = Describe("Build", func() {
3535
TemplatesDir: "./test",
3636
BuildDir: testDir,
3737
}
38+
3839
utils.CmdRunner = CreateNewFakeCmdRunner()
3940
})
41+
4042
AfterEach(func() {
4143
os.RemoveAll(testDir)
4244
})
@@ -72,8 +74,8 @@ var _ = Describe("Build", func() {
7274
}
7375

7476
var checkConfigureCmd = func(cmd exec.Cmd) {
75-
Expect(cmd.String()).To(Equal(
76-
"/usr/local/bin/docker run " +
77+
Expect(cmd.String()).To(ContainSubstring(
78+
"docker run " +
7779
"--env DISCOURSE_DB_HOST " +
7880
"--env DISCOURSE_DB_PASSWORD " +
7981
"--env DISCOURSE_DB_PORT " +
@@ -143,8 +145,8 @@ var _ = Describe("Build", func() {
143145
// commit on configure
144146
var checkConfigureCommit = func(cmd exec.Cmd) {
145147
Expect(cmd.String()).To(MatchRegexp(
146-
"/usr/local/bin/docker commit " +
147-
`--change LABEL org\.opencontainers\.image\.created="[\d\-T:+]+" ` +
148+
"docker commit " +
149+
`--change LABEL org\.opencontainers\.image\.created="[\d\-T:Z]+" ` +
148150
`--change CMD \["/sbin/boot"\] ` +
149151
"discourse-build-test local_discourse/test",
150152
))
@@ -154,7 +156,7 @@ var _ = Describe("Build", func() {
154156

155157
// configure also cleans up
156158
var checkConfigureClean = func(cmd exec.Cmd) {
157-
Expect(cmd.String()).To(Equal("/usr/local/bin/docker rm --force discourse-build-test"))
159+
Expect(cmd.String()).To(ContainSubstring("docker rm --force discourse-build-test"))
158160
}
159161

160162
It("Should run docker build with correct arguments", func() {

launcher_go/v2/docker/commands.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ func (r *DockerPupsRunner) Run() error {
270270
cmd := exec.Command("docker",
271271
"commit",
272272
"--change",
273-
"LABEL org.opencontainers.image.created=\""+time.Now().Format(time.RFC3339)+"\"",
273+
"LABEL org.opencontainers.image.created=\""+time.Now().UTC().Format(time.RFC3339)+"\"",
274274
"--change",
275275
"CMD [\""+r.Config.BootCommand()+"\"]",
276276
r.ContainerId,

0 commit comments

Comments
 (0)