Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fixes and update the README #26

Closed

Conversation

maruthimohan
Copy link

This pull request

  • fixes a potential issue reported by deepsource check
  • updates the README to add more information on how to use this extension and how to contribute to this extension

closes #12

@maruthimohan
Copy link
Author

@dit7ya could you please review this pull request?

@dit7ya
Copy link
Owner

dit7ya commented Oct 26, 2021

@maruthimohan Hi, thanks for the PR but the readme changes are not exactly to my writing style/taste.

Also I am reluctant to change readmore.js since it is a library of its own which I am just using. I can add hacktoberfest-approved to the PR though if you want.

@maruthimohan
Copy link
Author

@dit7ya sure, that sounds good. If you could add the hacktoberfest-accepted label to this pull request, that could be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a proper README
2 participants