Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DpError::ZeroDenominator #1074

Open
divergentdave opened this issue Jun 6, 2024 · 0 comments
Open

Remove DpError::ZeroDenominator #1074

divergentdave opened this issue Jun 6, 2024 · 0 comments
Labels
breaking change

Comments

@divergentdave
Copy link
Collaborator

divergentdave commented Jun 6, 2024 •
edited
Loading

It's sort of strange to me that a bad denominator gets its own special enum variant, but a bad numerator is a generic "invalid parameter". Do we expect the caller to do anything particular in the presence of either error? If not, then just returning DpError::InvalidParameter in both cases seems fine, and maybe we could remove ::ZeroDenominator the next time we break public API.

Originally posted by @tgeoghegan in #1072 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@divergentdave