Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDPF/Poplar1: Revisit use of bitvec::prelude::Lsb0 order #508

Open
divergentdave opened this issue Mar 10, 2023 · 2 comments
Open

IDPF/Poplar1: Revisit use of bitvec::prelude::Lsb0 order #508

divergentdave opened this issue Mar 10, 2023 · 2 comments

Comments

@divergentdave
Copy link
Collaborator

Implementing Encode and Decode for Poplar1AggregationParam is suggesting that Lsb0 may have not been a good choice for bit ordering in various intermediate storage data types. We may want to revisit this in the future to simplify things.
@divergentdave
Copy link
Collaborator Author

This will be addressed in the spec by cfrg/draft-irtf-cfrg-vdaf#433. We should be able to use Msb0 without any reversing.

@divergentdave divergentdave mentioned this issue Oct 8, 2024
Closed
19 tasks
@divergentdave
Copy link
Collaborator Author

#1171 changed the aggregation parameter format, so we no longer have the double reversing happening. We still use a combination of Lsb0 and Msb0. We should review this and see if we can stick to one internal representation for all bit vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@divergentdave