Skip to content

Commit fae4cd9

Browse files
committed
type hints: fixed some type hint problems
1 parent caae469 commit fae4cd9

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

django_valkey/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# mypy: disable-error-code="attr-defined"
12
import builtins
23
import time
34
from collections.abc import Iterator, AsyncIterator, Callable
@@ -133,7 +134,7 @@ def client(self) -> Client:
133134
"""
134135
if self._client is None:
135136
self._client = self._client_cls(self._server, self._params, self)
136-
return self._client
137+
return self._client # type: ignore[return-value]
137138

138139

139140
class SyncCacheCommands:

django_valkey/base_client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import builtins
2-
from collections.abc import Iterable
2+
from collections.abc import Sequence
33
import random
44
import socket
55
from typing import (
@@ -34,7 +34,7 @@
3434
class BaseClient:
3535
def __init__(
3636
self,
37-
server: str | Iterable,
37+
server: Sequence,
3838
params: dict[str, Any],
3939
backend: "ValkeyCache",
4040
) -> None:
@@ -44,7 +44,7 @@ def __init__(
4444
error_message = "Missing connections string"
4545
raise ImproperlyConfigured(error_message)
4646
if not isinstance(self._server, (list, tuple, set)):
47-
self._server = self._server.split(",")
47+
self._server = self._server.split(",") # type: ignore[attr-defined]
4848

4949
self._params = params
5050

@@ -75,14 +75,14 @@ def __init__(
7575
)
7676

7777
self._connection_factory = getattr(
78-
settings, "DJANGO_VALKEY_CONNECTION_FACTORY", self.CONNECTION_FACTORY_PATH
78+
settings, "DJANGO_VALKEY_CONNECTION_FACTORY", self.CONNECTION_FACTORY_PATH # type: ignore[attr-defined]
7979
)
8080
self.connection_factory = pool.get_connection_factory(
8181
options=self._options, path=self._connection_factory
8282
)
8383

8484
def __contains__(self, key: KeyT) -> bool:
85-
return self.has_key(key)
85+
return self.has_key(key) # type: ignore[attr-defined]
8686

8787
def _has_compression_enabled(self) -> bool:
8888
return (

0 commit comments

Comments
 (0)