Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement java.lang.AutoCloseable on portal.runtime.jvm.client.Portal #239

Open
devurandom opened this issue Sep 23, 2024 · 3 comments
Open

Comments

@devurandom
Copy link

If portal.runtime.jvm.client.Portal would implement java.lang.AutoCloseable, I could (with-open [_ (p/open {,,,})] ,,,).

@djblue
Copy link
Owner

djblue commented Sep 23, 2024

Interesting, what kind of use cases did you have in mind for this?

@devurandom
Copy link
Author

I built a test fixture for portal, so I can tap> values to IntelliJ from tests.

@djblue
Copy link
Owner

djblue commented Sep 26, 2024

Since the jvm implementation is the same one that runs on bb, and bb doesn't expose java.lang.AutoCloseable, I don't think portal can easily do this without forking the implementation a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants