Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The VSCode extension djlint should not require people to install the Python package #780

Open
nbro opened this issue Jun 16, 2024 · 4 comments

Comments

@nbro
Copy link

nbro commented Jun 16, 2024

Under the hood, the VSCode extension djlint should take care of installing djlint with pip or whatever in an isolated environment, which should be removed whenever we remove the extension. I shouldn't need to add this dependency to my pyproject.toml (with poetry) just to make the VSCode extension work.

@monosans
Copy link
Member

You can use pipx

@nbro
Copy link
Author

nbro commented Jun 16, 2024

My point is that I shouldn't need to use any Python package manager (pip, pipx, pip-tools, poetry, whatever) to make the VSCode extension work. We should just need maybe Python and that's it. So, the Python package should be installed automatically, in some virtual environment, whenever we install the VSCode extension, and it should be removed automatically, along with the virtual environment, whenever we remove the extension

@isoboroff
Copy link

isoboroff commented Oct 13, 2024

What if I have a global djlint installed (/opt/homebrew/bin/djlint, for example)?

The current behavior is to tell me to install djlint in the current venv.

@monosans
Copy link
Member

What if I have a global djlint installed (/opt/homebrew/bin/djlint, for example)?

The current behavior is to tell me to install djlint in the current venv.

Please read the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants