Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The data-type parameter is not used #6

Open
djpnewton opened this issue Nov 15, 2011 · 2 comments
Open

The data-type parameter is not used #6

djpnewton opened this issue Nov 15, 2011 · 2 comments

Comments

@djpnewton
Copy link
Owner

We need to decide whether to use it (ie do type checking of the referenced node).. or perhaps drop it
@djpnewton
Copy link
Owner Author

To clarify,

The data-type parameter of the read/write packets (https://github.com/djpnewton/kowhai/wiki/Communications-Protocol) is not currently used by kowhai_server_process_packet()

@othane
Copy link
Contributor

othane commented May 23, 2014

Can I take it from this issue that currently (and ideally for ever more) POPULATE_PROTOCOL_WRITE does not really need the data_type parameter (and we could get rid of this basted for ever in the macro, instead it would just put data_size bytes into the dst)

or is data_type needed for some other reason atm ?

othane referenced this issue in othane/kowhai Jul 28, 2014
@othane
Merge pull request #6 from othane/node_serializer
d34fb09 
clean up serialise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djpnewton @othane