Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try and eliminate remaining classes #215

Open
Herringway opened this issue Jan 11, 2019 · 0 comments
Open

Try and eliminate remaining classes #215

Herringway opened this issue Jan 11, 2019 · 0 comments
Assignees
@Herringway
Labels
enhancement optimization
Milestone
0.9.0

Comments

@Herringway
Copy link
Member

We should change the Composer, Parser, Reader, Resolver and Scanner classes into structs or free-standing functions.

  • We don't need the polymorphism (they're final anyway)
  • The near-requirement of heap placement is limiting us
    • We rely on the GC for cleanup
  • We don't want to deal with overriding methods and the drawbacks that come with them
@Herringway Herringway added this to the 0.8 milestone Jan 11, 2019
@Herringway Herringway self-assigned this Jan 11, 2019
@ghost ghost mentioned this issue Jan 15, 2019
Merged
@Herringway Herringway mentioned this issue Jan 15, 2019
Merged
@Herringway Herringway mentioned this issue Feb 5, 2019
Merged
@ghost ghost modified the milestones: 0.8, 0.9.0 May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Herringway Herringway

Labels
enhancement optimization
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@Herringway