Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dlang.org theme on the editor page #550

Closed
CyberShadow opened this issue Jun 28, 2017 · 3 comments
Closed

Use dlang.org theme on the editor page #550

CyberShadow opened this issue Jun 28, 2017 · 3 comments
Labels

Comments

@CyberShadow
Copy link

Currently the editor page is pretty bare-bones:

https://tour.dlang.org/editor

Would be nice to use the dlang.org theme, at least for the top navigation bar.

@wilzbach
Copy link
Member

The tour already has a copy of the Dlang navigation bar (e.g. https://tour.dlang.org)

I actually actively disabled it actively (https://github.com/dlang-tour/core/blob/master/views/base.dt#L16). Do you simply want the same navigation as on dlang.org?

@CyberShadow
Copy link
Author

CyberShadow commented Jun 28, 2017

Well, currently the page is completely devoid of branding, so at a glance it's not clear if it's a third-party website or if it's affiliated with dlang.org. Making it look like it's part of the network would be nice.

A very similar case is the forum, which uses dlang.org's navigation bar mostly verbatim.

wilzbach added a commit to wilzbach/dlang-tour that referenced this issue Jun 28, 2017
wilzbach added a commit to wilzbach/dlang-tour that referenced this issue Jun 28, 2017
@wilzbach
Copy link
Member

A very similar case is the forum, which uses dlang.org's navigation bar mostly verbatim.

Fair enough, shouldn't be hard then.
-> #553

wilzbach added a commit that referenced this issue Jul 2, 2017
Fix #550 - Use dlang.org theme on the editor page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants