Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting failures #72

Open
donaldgray opened this issue Jul 18, 2024 · 0 comments
Open

Detecting failures #72

donaldgray opened this issue Jul 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@donaldgray
Copy link
Member

We'll need to confirm whether there is ongoing but it seems like there may be an issue were task failure isn't detected correctly.

I initially thought this could be related to running out of resources (due to memory issue resolved in #71). When using the default django-q broker the max_retries seemed to be ignored, items were continuously picked up and aborted. The endpoint to check status wasn't returning an error.

#68 added support for SQS broker, it also looks like max_retries is ignored in this case. I tested using deadletter queues via SQS to detect failures but in this instance we need to investigate how we can determine which message has failed. The tasks are pickled and signed so we'd need to investigate whether it is possible or not. Does the API / worker may need to listen to the DLQ and mark the task as failed? Is there a standard pattern for this?

This may be releated to how the API has been implemented and something has been overlooked.

@donaldgray donaldgray added the enhancement New feature or request label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant