Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy timeouts should be configurable #805

Closed
donaldgray opened this issue Apr 12, 2024 · 1 comment · Fixed by #842
Closed

Proxy timeouts should be configurable #805

donaldgray opened this issue Apr 12, 2024 · 1 comment · Fixed by #842

Comments

@donaldgray
Copy link
Member

We currently have a hardcoded timeout value for all Yarp proxy requests, which is set too high (60s across the board).

Make this configurable per target, we may want a default of XXs which targets can optionally override (to avoid needing a value for all). Ideally pull this from config. Can this be read from Yarp config, similar to how we read endpoint addresses?

This is set via ForwarderRequestConfig.ActivityTimeout. This seems to be causing issues if downstream service is in distress - currently only seen with image-server if a general failure happens across all instances. Do we need to consider #769 when implementing this (probably not - this can be timeout and #769 can add circuit breaker or hedging policy for downstream requests?).

@donaldgray
Copy link
Member Author

Closing as done, in release https://github.com/dlcs/protagonist/releases/tag/v1.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant