Only run build + test for draft PRs #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldgray
requested review from
tomcrane,
griffri,
JackLewis-digirati and
p-kaczynski
|
@JackLewis-digirati / @griffri - what are the thoughts on this? Wondering if we should bother running tests on draft PRs? |
|
I think running the tests would be useful, I could see a time when some tests weren't run and now fail, meaning the PR needs to go back to the drawing board for additional work - by comparison, if the tests ran on draft, it would more quickly point out that there's unexpected issues in the PR |
|
I agree with Jack - I think it would be useful to continue allowing tests run on draft PRs. It's good for spotting any overlooked issues before opening up the PR. |
JackLewis-digirati
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this is the best way to approach it; intent is to reduce build churn for draft PRs.