Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wrong comment in ndarray_bakcend_cuda.cu #9

Open
lzymmm123 opened this issue Dec 14, 2022 · 0 comments
Open

The wrong comment in ndarray_bakcend_cuda.cu #9

lzymmm123 opened this issue Dec 14, 2022 · 0 comments

Comments

@lzymmm123
Copy link

In src/ ndarray_bakcend_cuda.cu file, The comment of the parameter 'strides' and 'offset' with the function CompactKernel and Compact is not consistency.

CompactKernel:

*   strides: vector of strides of out array
*   offset: offset of out array

Compact:

* strides: strides of the *a* array (not out, which has compact strides)
*  offset: offset of the *a* array (not out, which has zero offset, being compact)

I think the parameters strides and offsets all belong to the input array "a".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant