From 5a1cb69a31ffbe82cf0f00fb65b94e05e7310763 Mon Sep 17 00:00:00 2001 From: Alena Astrakhantseva Date: Wed, 18 Dec 2024 22:19:31 +0100 Subject: [PATCH] fix credentials link (add slash) (#2162) --- dlt/cli/deploy_command_helpers.py | 2 +- dlt/common/configuration/exceptions.py | 2 +- dlt/extract/decorators.py | 4 ++-- docs/website/docs/general-usage/credentials/setup.md | 2 +- docs/website/docs/walkthroughs/run-a-pipeline.md | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlt/cli/deploy_command_helpers.py b/dlt/cli/deploy_command_helpers.py index e3719fbe38..fba528acf7 100644 --- a/dlt/cli/deploy_command_helpers.py +++ b/dlt/cli/deploy_command_helpers.py @@ -239,7 +239,7 @@ def _display_missing_secret_info(self) -> None: " available configuration ie. secrets.toml file. Please run the deploy command from" " the same working directory you ran your pipeline script. If you pass the" " credentials in code we will not be able to display them here. See" - " https://dlthub.com/docs/general-usage/credentials" + " https://dlthub.com/docs/general-usage/credentials/" ) def _lookup_secret_value(self, trace: LookupTrace) -> Any: diff --git a/dlt/common/configuration/exceptions.py b/dlt/common/configuration/exceptions.py index 1d8423057f..1c6130f9d4 100644 --- a/dlt/common/configuration/exceptions.py +++ b/dlt/common/configuration/exceptions.py @@ -75,7 +75,7 @@ def __str__(self) -> str: " run your script from some other folder, secrets/configs will not be found\n" ) msg += ( - "Please refer to https://dlthub.com/docs/general-usage/credentials for more" + "Please refer to https://dlthub.com/docs/general-usage/credentials/ for more" " information\n" ) return msg diff --git a/dlt/extract/decorators.py b/dlt/extract/decorators.py index f8703e1452..8444f70489 100644 --- a/dlt/extract/decorators.py +++ b/dlt/extract/decorators.py @@ -374,7 +374,7 @@ def source( >>> list(chess("magnuscarlsen")) Here `username` is a required, explicit python argument, `chess_url` is a required argument, that if not explicitly passed will be taken from configuration ie. `config.toml`, `api_secret` is a required argument, that if not explicitly passed will be taken from dlt secrets ie. `secrets.toml`. - See https://dlthub.com/docs/general-usage/credentials for details. + See https://dlthub.com/docs/general-usage/credentials/ for details. Args: func: A function that returns a dlt resource or a list of those or a list of any data items that can be loaded by `dlt`. @@ -564,7 +564,7 @@ def resource( >>> list(user_games("magnuscarlsen")) Here `username` is a required, explicit python argument, `chess_url` is a required argument, that if not explicitly passed will be taken from configuration ie. `config.toml`, `api_secret` is a required argument, that if not explicitly passed will be taken from dlt secrets ie. `secrets.toml`. - See https://dlthub.com/docs/general-usage/credentials for details. + See https://dlthub.com/docs/general-usage/credentials/ for details. Note that if decorated function is an inner function, passing of the credentials will be disabled. Args: diff --git a/docs/website/docs/general-usage/credentials/setup.md b/docs/website/docs/general-usage/credentials/setup.md index b8f60e8156..dacb41da52 100644 --- a/docs/website/docs/general-usage/credentials/setup.md +++ b/docs/website/docs/general-usage/credentials/setup.md @@ -665,7 +665,7 @@ dlt.common.configuration.exceptions.ConfigFieldMissingException: Following field In secrets.toml key destination.postgres.credentials.password was not found. In secrets.toml key destination.credentials.password was not found. In secrets.toml key credentials.password was not found. -Please refer to https://dlthub.com/docs/general-usage/credentials for more information +Please refer to https://dlthub.com/docs/general-usage/credentials/ for more information ``` It tells you exactly which paths `dlt` looked at, via which config providers and in which order. diff --git a/docs/website/docs/walkthroughs/run-a-pipeline.md b/docs/website/docs/walkthroughs/run-a-pipeline.md index 3c0e30ccf3..f0bc10fe07 100644 --- a/docs/website/docs/walkthroughs/run-a-pipeline.md +++ b/docs/website/docs/walkthroughs/run-a-pipeline.md @@ -186,7 +186,7 @@ dlt.common.configuration.exceptions.ConfigFieldMissingException: Following field In secrets.toml key destination.postgres.credentials.password was not found. In secrets.toml key destination.credentials.password was not found. In secrets.toml key credentials.password was not found. -Please refer to https://dlthub.com/docs/general-usage/credentials for more information +Please refer to https://dlthub.com/docs/general-usage/credentials/ for more information ``` What does this exception tell you?