Skip to content

Commit 838e678

Browse files
committed
Support validating tar files by skipping the Docker pull if the image is local. Skip the Docker validations in the run-smoke-tests.sh script altogether to rely on the e2e-tests. Increase validation time to 30 minutes.
Signed-off-by: David Venable <[email protected]>
1 parent 4797aee commit 838e678

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ jobs:
9797
fail-fast: false
9898
runs-on: ubuntu-latest
9999
needs: build
100-
timeout-minutes: 8
100+
timeout-minutes: 30
101101

102102
steps:
103103
- name: Checkout Data Prepper

e2e-test/build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,9 @@ subprojects {
8585

8686
tasks.register('dataPrepperDockerImage', DockerProviderTask) {
8787
if(dataPrepperDefinedDockerImage != null) {
88-
dependsOn 'pullDataPrepperDockerImage'
88+
if(dataPrepperDefinedDockerImage.contains('/')) {
89+
dependsOn 'pullDataPrepperDockerImage'
90+
}
8991
imageId = "${dataPrepperDefinedDockerImage}"
9092
}
9193
else if(targetJavaVersion == 'docker') {

release/smoke-tests/run-smoke-tests.sh

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ done
5656

5757
export DOCKER_IMAGE="${IMAGE_NAME}:${TAG_NAME}"
5858

59-
# Check the Docker image before running
60-
if ! docker inspect --type=image "${DOCKER_IMAGE}" > /dev/null
61-
then
62-
echo "--------------------------------------------------------------------------"
63-
echo "Unable to find image \"${DOCKER_IMAGE}\" are you sure it exists?"
64-
end_tests 1
65-
fi
66-
6759
echo "Will smoke test image \"${DOCKER_IMAGE}\""
6860

6961
./gradlew -PendToEndDataPrepperImage=${IMAGE_NAME} -PendToEndDataPrepperTag=${TAG_NAME} :e2e-test:log:basicLogEndToEndTest

0 commit comments

Comments
 (0)