Merge branch 'master' into 5.6

Author: dmitry-ivanov

README.md

@@ -75,6 +75,9 @@ Provides Laravel-specific and pure PHP helper functions.
     - [str_lower](#str_lower)
     - [str_upper](#str_upper)
 
+- [System](#system)
+    - [is_windows_os](#is_windows_os)
+
 - [Xml](#xml)
     - [xml_to_array](#xml_to_array)
     - [array_to_xml](#array_to_xml)
@@ -437,6 +440,18 @@ $upper = str_upper('TeSt');
 // TEST
 ```
 
+## System
+
+#### `is_windows_os()`
+
+Checks if php is running on Windows OS or not:
+
+```php
+$isWindowsOs = is_windows_os();
+
+// boolean
+```
+
 ## Xml
 
 #### `xml_to_array()`

src/classes/Artisan/Command.php

@@ -31,6 +31,10 @@ public function runInBackground()
 
     protected function composeForRunInBackground()
     {
+        if (is_windows_os()) {
+            return "start /B {$this->composeForRun()}";
+        }
+
         return "({$this->composeForRun()}) > /dev/null 2>&1 &";
     }
 

src/classes/System/OS.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Illuminated\Helpers\System;
+
+class OS
+{
+    public static function isWindows()
+    {
+        return (strtoupper(substr(php_uname(), 0, 7)) === 'WINDOWS');
+    }
+}

src/system.php

@@ -0,0 +1,10 @@
+<?php
+
+use Illuminated\Helpers\System\OS;
+
+if (!function_exists('is_windows_os')) {
+    function is_windows_os()
+    {
+        return OS::isWindows();
+    }
+}

tests/HelperFunctions/TestCase.php

@@ -20,6 +20,18 @@ protected function setUp()
         self::$functions = mock();
     }
 
+    protected function emulateLinuxOs()
+    {
+        self::$functions->expects()->php_uname()
+            ->andReturns('Linux localhost 2.4.21-0.13mdk #1 Fri Mar 14 15:08:06 EST 2003 i686');
+    }
+
+    protected function emulateWindowsOs()
+    {
+        self::$functions->expects()->php_uname()
+            ->andReturns('Windows NT XN1 5.1 build 2600');
+    }
+
     protected function expectsExecWith($command)
     {
         self::$functions->expects()->exec($command);

tests/HelperFunctions/classes/Artisan/CommandTest.php

@@ -28,7 +28,11 @@ public function it_has_static_constructor_named_factory()
         $this->assertInstanceOf(Command::class, $command);
     }
 
-    /** @test */
+    /**
+     * @test
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function it_can_run_command_in_background()
     {
         $this->expectsExecWith('(php artisan test:command) > /dev/null 2>&1 &');
@@ -38,6 +42,22 @@ public function it_can_run_command_in_background()
     }
 
     /** @test */
+    public function which_also_works_for_windows()
+    {
+        require_once 'mocks.php';
+
+        $this->emulateWindowsOs();
+        $this->expectsExecWith('start /B php artisan test:command');
+
+        $command = Command::factory('test:command');
+        $command->runInBackground();
+    }
+
+    /**
+     * @test
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function run_in_background_supports_before_subcommand()
     {
         $this->expectsExecWith('(before command && php artisan test:command) > /dev/null 2>&1 &');
@@ -46,7 +66,11 @@ public function run_in_background_supports_before_subcommand()
         $command->runInBackground();
     }
 
-    /** @test */
+    /**
+     * @test
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function run_in_background_supports_after_subcommand()
     {
         $this->expectsExecWith('(php artisan test:command && after command) > /dev/null 2>&1 &');
@@ -55,7 +79,11 @@ public function run_in_background_supports_after_subcommand()
         $command->runInBackground();
     }
 
-    /** @test */
+    /**
+     * @test
+     * @runInSeparateProcess
+     * @preserveGlobalState disabled
+     */
     public function run_in_background_supports_before_and_after_subcommands_together()
     {
         $this->expectsExecWith('(before && php artisan test:command && after) > /dev/null 2>&1 &');

tests/HelperFunctions/classes/Artisan/mocks.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Illuminated\Helpers\System
+{
+    use Illuminated\Helpers\HelperFunctions\Tests\TestCase;
+
+    if (!function_exists(__NAMESPACE__ . '\php_uname')) {
+        function php_uname()
+        {
+            return TestCase::$functions->php_uname();
+        }
+    }
+}

tests/HelperFunctions/system/IsWindowsOsTest.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Illuminated\Helpers\System;
+
+use Illuminated\Helpers\HelperFunctions\Tests\TestCase;
+
+class IsWindowsOsTest extends TestCase
+{
+    /** @test */
+    public function it_returns_false_on_non_windows_os()
+    {
+        $this->emulateLinuxOs();
+
+        $this->assertFalse(is_windows_os());
+    }
+
+    /** @test */
+    public function it_returns_true_on_windows_os()
+    {
+        $this->emulateWindowsOs();
+
+        $this->assertTrue(is_windows_os());
+    }
+}
+
+if (!function_exists(__NAMESPACE__ . '\php_uname')) {
+    function php_uname()
+    {
+        return TestCase::$functions->php_uname();
+    }
+}