-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xgboost failing with julia 1.8.5 #179
Comments
Can you show the full stack trace? I can't reproduce any error. |
Yes, please post stack trace, but my guess is JuliaLang/julia#48187 . Only workaround I know of is downgrade julia to < 1.8.4 or use non-windows machine |
How do I generate the full stack trace? Running on Windows 11 |
Oh, I didn't notice this was windows, yeah it's probably that. Also Julia 1.9 just came out today so that might work (and it's best to upgrade anyway).
What appears when you see the error? |
Unfortunately the problem hasn't been resolved with Julia v1.9. |
Yeah, didn't fix the issue when I tried in 1.9.0 as well. Seems to be ongoing since 1.8.4. |
I'm getting the sense that there are a lack of windows people around to debug the issue. I don't think any of us who have made recent commits to this package are capable of debugging the issue. Probably something JLL related but 🤷 |
As discussed in the linked discourse thread, it seems to be an incompatibility arising after an update to building julia under gcc 12 since v1.8.4, and the libgomp (OpenMP) library. A possible work-around is to use your own system's version of libgomp, but not a good long-term solution. And, yes, it needs someone who knows how to debug windows crashes. |
Do we know what library that xgboost relies on has libgomp as a build dependency? I'm wondering if it could be as simple as updating a jll build script, but I don't even know which one my specify this as a dependency. |
The julia stdlib CompilerSupportLibraries and the CompilerSupportLibraries_jll supply a specific See also my halting attempts: https://discourse.julialang.org/t/issue-with-xgboost-jl-and-libsvm-jl-when-julia-1-8-4/92396/28?u=jd-foster |
Ok, quick and dirty fix to at least avoid crashes. As noted above, offending library seems to be libgomp-1.dll that is installed in the bin directory. Replacing with the 1.8.3 version seems to fix the crashes. Mode LastWriteTime Length Name -a--- 11/14/2022 1:07 PM 1761059 libgomp-1.dll the 1_9_0 version (second one) comes with 1.8.5 and 1.9.0, the first one is from 1.8.3. For now, just replace this one if you need to use XGBoost. Of course, someone needs to figure out why libgomp-1.dll.installed_1_9_0 crashes. |
Seems like a duplicate of #153? |
Fixed in Julia master by JuliaLang/julia#50135 (and yes, this is a duplicate) |
Thanks so much for your efforts on this @giordano . |
I merely executed the solution found by @jd-foster 🙂 |
Ok, well thanks @jd-foster then! |
I reported the fact that this issue has been fixed (at least on Julia |
I'll wait until 1.9.2 is out and we see CI/CD pass to close them. |
For CI you can check it works on nightly, like JuliaApproximation/FastTransforms.jl#222 |
Issue fixed in latest nightly 👍 . Great job @jd-foster and @giordano. julia> b = xgboost((X,y), max_depth=4) |
We should be good to go. All the tests are now green thanks to Julia |
As with #153, I believe this is now resolved on 1.9.2. Please re-open if this is not the case. |
XGBoost version 2.2.5
Julia Version 1.8.5
Commit 17cfb8e65e (2023-01-08 06:45 UTC)
Platform Info:
OS: Windows (x86_64-w64-mingw32)
CPU: 8 × Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-13.0.1 (ORCJIT, skylake)
Threads: 1 on 8 virtual cores
--- sample code below crashes at the last line
using XGBoost
using DataFrames
(X,y) = (DataFrame(randn(100,3), [:l, :r, :u]), randn(100))
b = xgboost((X,y), max_depth=4)
The text was updated successfully, but these errors were encountered: