Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 and 7 dice options don't appear to be working correctly? #54

Open
SN7400 opened this issue Aug 14, 2024 · 2 comments
Open

6 and 7 dice options don't appear to be working correctly? #54

SN7400 opened this issue Aug 14, 2024 · 2 comments
Assignees

Comments

@SN7400
Copy link

SN7400 commented Aug 14, 2024

Hello, I tried the 6 and 7 dice options (?dice=6 and ?dice=7) on Firefox and Edge on Windows. The animations for both still show 5 dice, and the words generated all appear to be contained in the 5 dice EFF list. Is it user error, an issue with my environment, or a bug? Thanks.

@dmuth dmuth self-assigned this Aug 14, 2024
@dmuth
Copy link
Owner

dmuth commented Aug 14, 2024

Hi, it wasn't you, it was me. :-)

I used to have support for 6 and 7 word wordlists, but removed them awhile ago because some of the words in them were hardly used in the English language, and I felt that password creation with those words would make passwords harder to remember and potentially alienate users of the app.

But while I removed code for those word lists, I forgot to update the index.html, so that's 100% on me, sorry about that! I just pushed out an update to https://diceware.dmuth.org/ that explains why those wordlists are no longer supported in my Diceware implementation.

Best,

-- Doug

@SN7400
Copy link
Author

SN7400 commented Aug 16, 2024

Hi, no problem, thank you for the clarification! Do you think it might be a good idea to also display some kind of warning or error when someone uses ?dice=6 or ?dice=7 (or even any ?dice=*), in case someone is used to doing that and doesn't read the rest of the page anymore? Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants