Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bower from required dependencies #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jaboy1409
Copy link

Saves needing to install bower to use this as a dependency.

npm install is now all you need to run.

@cmalard
Copy link

cmalard commented Dec 8, 2016

Fix #66

Thanks for the PR jaboy1409 :-)

  • you can remove bower.json
  • maybe update the README to mention NPM install
  • why updating grunt-contrib-jshint ? (it seems not related to bower removal)

👍

@cmalard
Copy link

cmalard commented Jan 9, 2017

@jaboy1409 as this is a PR, you should change

+Download package(until merged into master)
 ```sh
-bower install angular-advanced-searchbox
+npm install

by

 ```sh
-bower install angular-advanced-searchbox
+npm install angular-advanced-searchbox --save

@dnauck dnauck added the wontfix label Nov 9, 2017
@dnauck
Copy link
Owner

dnauck commented Nov 9, 2017

Hi @jaboy1409 ,

thanks for your pull request. But removing bower is not an option as this library is still deployed to bower.

@dnauck dnauck self-assigned this Nov 9, 2017
@cmalard
Copy link

cmalard commented Nov 9, 2017

Hi @dnauck , Bower is deprecated, so why not ?

-> Migration Path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants