Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMessageFormatter param is not nullable #37

Closed
onatsko opened this issue Oct 27, 2024 · 2 comments · Fixed by #38
Closed

IMessageFormatter param is not nullable #37

onatsko opened this issue Oct 27, 2024 · 2 comments · Fixed by #38
Assignees
@a-gubskiy
Labels
bug Something isn't working

Comments

@onatsko
Copy link
Collaborator

onatsko commented Oct 27, 2024

I use your lib for sending message to Telegram, it works great, thank you!

But today I enable nullable in project
and get error on code:

   logConfig = logConfig.WriteTo.Telegram(config => { ....  }, null, logLevelError);

null is param IMessageFormatter messageFormatter

in ctor I see that it is not nullable

    public static LoggerConfiguration Telegram(
      this LoggerSinkConfiguration loggerConfiguration,
      Action<TelegramSinkConfiguration> configureAction,
      IMessageFormatter messageFormatter,
      LogEventLevel restrictedToMinimumLevel = LogEventLevel.Verbose)

but in next ctor TelegramSink is nullable

    public TelegramSink(
      ChannelWriter<LogEvent> channelWriter,
      ILogsQueueAccessor logsQueueAccessor,
      TelegramSinkConfiguration sinkConfiguration,
      IMessageFormatter? messageFormatter)

pls make IMessageFormatter nullable in LoggerConfiguration Telegram
@a-gubskiy a-gubskiy self-assigned this Oct 27, 2024
@a-gubskiy a-gubskiy linked a pull request Oct 27, 2024 that will close this issue
37 IMessageFormatter and other fixes #38
Merged
@a-gubskiy a-gubskiy added the bug Something isn't working label Oct 27, 2024
@a-gubskiy
Copy link
Member

@onatsko please check this version: https://www.nuget.org/packages/X.Extensions.Logging.Telegram/2.0.1-rc

@onatsko onatsko closed this as completed Nov 27, 2024
@onatsko
Copy link
Collaborator Author

onatsko commented Nov 27, 2024

thanx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-gubskiy a-gubskiy

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

37 IMessageFormatter and other fixes dncuug/X.Extensions.Logging.Telegram
2 participants
@a-gubskiy @onatsko