Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Group updater: add support for parallelism #236

Open
wfarner opened this issue Oct 17, 2016 · 2 comments
Open

Group updater: add support for parallelism #236

wfarner opened this issue Oct 17, 2016 · 2 comments

Comments

@wfarner
Copy link
Contributor

wfarner commented Oct 17, 2016

Addresses this TODO in rollingupdate.go:

// TODO(wfarner): Make the 'batch size' configurable.

We should accept a parallelism flag for updates to allow multiple instances to be drained simultaneously.

@chungers
Copy link
Contributor

I wonder where this will go. Is this a responsibility of Flavor or the group? I would think the Flavor worries about how to do a drain, and Group worries about how many at a time -- assuming different instances can be drained in parallel.

It's the inverse of the instance's Provision. So in the sense that a Flavor's Prepare is chained to the Instance's Provision, a Flavor's Drain should be chained to the Instance's Destroy.

Related #235

@wfarner
Copy link
Contributor Author

wfarner commented Oct 20, 2016

Flavor's Drain should be chained to the Instance's Destroy

That's exactly what i was thinking.

There are some use cases that we should anticipate (but probably not solve yet) - where parallelism should be selective. For example, in a Swarm we would ideally not pick all N instances hosting a particular service.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants