Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servicePath is not well manage #12

Open
pgodot01 opened this issue Oct 30, 2017 · 6 comments
Open

servicePath is not well manage #12

pgodot01 opened this issue Oct 30, 2017 · 6 comments

Comments

@pgodot01
Copy link

Thanks for this stack.

I tried to configure demo micro service with following configuration in my docker stack:

deploy:
  labels:
    - com.df.notify=true
    - com.df.distribute=true
    - com.df.servicePath=/demo
    - com.df.port=8080

In my swarm-listener logs, I got:
monitor_swarm-listener.1.yykqznc875td@manager | 2017/10/30 12:00:18 Sending service created notification to http://monitor:8080/v1/docker-flow-monitor/reconfigure?distribute=true&port=8080&replicas=1&serviceName=demo_main&servicePath=%2Fdemo

But in my monitor_monitor logs, I got:
monitor_monitor.1.vcn8myrn9igg@manager | 2017/10/30 12:00:18 Processing /v1/docker-flow-monitor/reconfigure?distribute=true&port=8080&replicas=1&serviceName=demo_main&servicePath=**%!F(MISSING)**demo
monitor_monitor.1.vcn8myrn9igg@manager | GLOBAL_SCRAPE_INTERVAL=10s

I have this strange MISSING string. Any Idea why ?

Thanks
Phil

@pgodot01
Copy link
Author

Does go_demo expose metrics on /demo URI or on /metrics ?

@vfarcic
Copy link
Collaborator

vfarcic commented Oct 30, 2017

It exposes them on /metrics (https://github.com/vfarcic/go-demo/blob/master/main.go#L73).

@pgodot01
Copy link
Author

Is it possible to configure the metrics_path of prometheus scrap in the monitored container? My application is exposing its metrics at /prometheus.

@vfarcic
Copy link
Collaborator

vfarcic commented Oct 30, 2017

It's added in the release 17.10.30-22. Can you please try it out and let me know whether it works as expected?

@pgodot01
Copy link
Author

Yes with pleasure. I checked your commit. It seems what I need. Have you implemented a verb version in your api to check if my docker image is up to date?

@pgodot01
Copy link
Author

Well done it's working like a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants