Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Convertigo 8.3.1 release #17589

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

nicolas-albert
Copy link
Contributor

Thx!

This comment has been minimized.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, there's no Dockerfile changes there. 🤔

@nicolas-albert
Copy link
Contributor Author

My bad, you're totally right!
Thx you for watching each details 👍

Copy link

Diff for 663a8ec:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 94945db..ceef89f 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,7 +1,7 @@
 Maintainers: Nicolas Albert <[email protected]> (@nicolas-albert), Olivier Picciotto <[email protected]> (@opicciotto)
 GitRepo: https://github.com/convertigo/convertigo
-GitCommit: b2b3387e1d01034c010817e14de30f2ce60febdc
+GitCommit: fc2b338e7de86f316c01b00027aed7fc42c54322
 
-Tags: 8.3.0, 8.3, latest
+Tags: 8.3.1, 8.3, latest
 Architectures: amd64, arm64v8
 Directory: docker/default
diff --git a/_bashbrew-list b/_bashbrew-list
index 1844919..fed159b 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,3 +1,3 @@
 convertigo:8.3
-convertigo:8.3.0
+convertigo:8.3.1
 convertigo:latest
diff --git a/convertigo_latest/Dockerfile b/convertigo_latest/Dockerfile
index 08536cd..f58157b 100644
--- a/convertigo_latest/Dockerfile
+++ b/convertigo_latest/Dockerfile
@@ -83,7 +83,7 @@ RUN sed -i.bak \
     && chmod -w conf/* \
     && chmod 777 conf/context.xml conf/server.xml
 
-ENV CONVERTIGO_VERSION 8.3.0
+ENV CONVERTIGO_VERSION 8.3.1
 
 ENV CONVERTIGO_WAR_URL https://github.com/convertigo/convertigo/releases/download/$CONVERTIGO_VERSION/convertigo-$CONVERTIGO_VERSION.war

Relevant Maintainers:

@tianon
Copy link
Member

tianon commented Sep 19, 2024

Oh no 😭 😂 ❤️

Step 13/20 : RUN export GNUPGHOME="$(mktemp -d)"     && ( gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$CONVERTIGO_GPG_KEYS"     || gpg --batch --keyserver keyserver.pgp.com --recv-keys "$CONVERTIGO_GPG_KEYS" )     && curl -fSL -o /tmp/convertigo.war $CONVERTIGO_WAR_URL     && curl -fSL -o /tmp/convertigo.war.asc $CONVERTIGO_WAR_URL.asc     && gpg --batch --verify /tmp/convertigo.war.asc /tmp/convertigo.war     && mkdir -p webapps/ROOT webapps/convertigo     && mkdir /certs && chmod 777 /certs     && (cd webapps/convertigo         && unzip -q /tmp/convertigo.war         && chmod 777 WEB-INF/web.xml WEB-INF/lib WEB-INF/classes         && rm -rf /tmp/*)
 ---> Running in 350ac108326c
gpg: keybox '/tmp/tmp.0HhbyUG0mK/pubring.kbx' created
gpg: /tmp/tmp.0HhbyUG0mK/trustdb.gpg: trustdb created
gpg: key D4DA8FBEB64BF75F: public key "Convertigo (mBaaS and Enterprise Mobility Platform) <[email protected]>" imported
gpg: Total number processed: 1
gpg:               imported: 1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     9    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
 ---> Removed intermediate container 350ac108326c
The command '/bin/sh -c export GNUPGHOME="$(mktemp -d)"     && ( gpg --batch --keyserver keyserver.ubuntu.com --recv-keys "$CONVERTIGO_GPG_KEYS"     || gpg --batch --keyserver keyserver.pgp.com --recv-keys "$CONVERTIGO_GPG_KEYS" )     && curl -fSL -o /tmp/convertigo.war $CONVERTIGO_WAR_URL     && curl -fSL -o /tmp/convertigo.war.asc $CONVERTIGO_WAR_URL.asc     && gpg --batch --verify /tmp/convertigo.war.asc /tmp/convertigo.war     && mkdir -p webapps/ROOT webapps/convertigo     && mkdir /certs && chmod 777 /certs     && (cd webapps/convertigo         && unzip -q /tmp/convertigo.war         && chmod 777 WEB-INF/web.xml WEB-INF/lib WEB-INF/classes         && rm -rf /tmp/*)' returned a non-zero code: 22

@nicolas-albert
Copy link
Contributor Author

Nightmare, the release was published with -beta ...
I think I have to relaunch it!

@tianon
Copy link
Member

tianon commented Sep 19, 2024

Just to be clear, you need the CI here restarted, or you need to do more upstream work (re-release, etc)? 🙇

@nicolas-albert
Copy link
Contributor Author

It should be good now.
Files exist now:
https://github.com/convertigo/convertigo/releases/download/8.3.1/convertigo-8.3.1.war
https://github.com/convertigo/convertigo/releases/download/8.3.1/convertigo-8.3.1.war.asc

(was 8.3.1/convertigo-8.3.1-beta.war due to a mistake)

I have prepared the build.gradle to release (8.3.1-beta -> 8.3.1), make and push the tag then the CI push the release on GitHub. I realized the build.gradle wasn't commit ... so I retag, double release on GitHub and ... delete the good release and let the -beta!

Sad story 😭

Thx you again for your work 🙏

@yosifkit yosifkit merged commit 7a8ed70 into docker-library:master Sep 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants