WIP: return early on error, and don't save

thaJeztah · thaJeztah · commit 1e99b255f413 · 2025-09-08T15:23:23.000+02:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go
@@ -164,6 +164,7 @@ func loginWithStoredCredentials(ctx context.Context, dockerCLI command.Cli, auth
 		} else {
 			_, _ = fmt.Fprintln(dockerCLI.Err(), "Login did not succeed, error:", err)
 		}
+		return err
 	}
 
 	if response.IdentityToken != "" {

Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ func loginWithStoredCredentials(ctx context.Context, dockerCLI command.Cli, auth`
`164`	`164`	`} else {`
`165`	`165`	`_, _ = fmt.Fprintln(dockerCLI.Err(), "Login did not succeed, error:", err)`
`166`	`166`	`}`
	`167`	`+ return err`
`167`	`168`	`}`
`168`	`169`
`169`	`170`	`if response.IdentityToken != "" {`