cli/command/secret: fix completion to complete names, not IDs

thaJeztah · thaJeztah · commit 924dd4710bdb · 2025-09-10T11:45:21.000+02:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/secret/cmd.go b/cli/command/secret/cmd.go
@@ -44,7 +44,7 @@ func completeNames(dockerCLI completion.APIClientProvider) cobra.CompletionFunc
 		}
 		var names []string
 		for _, secret := range list {
-			names = append(names, secret.ID)
+			names = append(names, secret.Spec.Name)
 		}
 		return names, cobra.ShellCompDirectiveNoFileComp
 	}

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ func completeNames(dockerCLI completion.APIClientProvider) cobra.CompletionFunc`
`44`	`44`	`}`
`45`	`45`	`var names []string`
`46`	`46`	`for _, secret := range list {`
`47`		`- names = append(names, secret.ID)`
	`47`	`+ names = append(names, secret.Spec.Name)`
`48`	`48`	`}`
`49`	`49`	`return names, cobra.ShellCompDirectiveNoFileComp`
`50`	`50`	`}`