e2e: remove workarounds for testing against dind < v24.0

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Author: thaJeztah

e2e/testdata/Dockerfile.connhelper-ssh

@@ -6,15 +6,10 @@ ARG ENGINE_VERSION=28
 
 FROM docker:${ENGINE_VERSION}-dind
 
-# the openssh-client update is needed for security reasons when using docker:23.0-dind, currently maintained as an lts by mirantis
-RUN apk --no-cache add openssl openssh-client openssh-server && \
-  apk --no-cache add shadow && \
-  # TODO(krissetto): `groupadd` can be removed once we only test against moby >= v24
-  # see https://github.com/docker-library/docker/pull/470
-  groupadd -f docker && \
-  useradd --create-home --shell /bin/sh --password $(head -c32 /dev/urandom | base64) penguin && \
-  usermod -aG docker penguin && \
-  ssh-keygen -A
+RUN apk --no-cache add openssl openssh-client openssh-server shadow \
+ && useradd --create-home --shell /bin/sh --password $(head -c32 /dev/urandom | base64) penguin \
+ && usermod -aG docker penguin \
+ && ssh-keygen -A
 # workaround: ssh session excludes /usr/local/bin from $PATH
 RUN  ln -s /usr/local/bin/docker /usr/bin/docker
 COPY ./connhelper-ssh/entrypoint.sh /