Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PRIVATE_PORT optional for docker compose port #11859

Open
crazybolillo opened this issue May 29, 2024 · 1 comment
Open

Make PRIVATE_PORT optional for docker compose port #11859

crazybolillo opened this issue May 29, 2024 · 1 comment
Labels
area/cli kind/feature

Comments

@crazybolillo
Copy link

Description

"Normal" docker already does this. See the usage for docker port:

$ docker port --help

Usage: docker port CONTAINER [PRIVATE_PORT[/PROTO]]

However docker compose differs:

$ docker compose port --help

Usage:  docker compose port [OPTIONS] SERVICE PRIVATE_PORT

I can look into making a PR if you agree this should be optional.
@ndeloof
Copy link
Contributor

ndeloof commented May 29, 2024

makes sense we align with the docker port command
I can't wait for your PR :)

crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 1, 2024
@crazybolillo
Make port arg optional in docker compose port
df79b5f 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 1, 2024
@crazybolillo
Make port arg optional in docker compose port
b63e8fa 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
@crazybolillo crazybolillo mentioned this issue Jun 1, 2024
Closed
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 1, 2024
@crazybolillo
Make port arg optional in docker compose port
9670fd8 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 1, 2024
@crazybolillo
Make port arg optional in docker compose port
c87db39 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 4, 2024
@crazybolillo
Make port arg optional in docker compose port
357c13b 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 4, 2024
@crazybolillo
Make port arg optional in docker compose port
21c0a70 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
crazybolillo added a commit to crazybolillo/compose that referenced this issue Jun 12, 2024
@crazybolillo
Make port arg optional in docker compose port
96514e4 
This comand no longer needs a mandatory port. If no port is provided it
will instead list all published ports. This behavior falls in line with
the behavior provided by `docker port`.

Closes docker#11859.

Signed-off-by: Antonio Aguilar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make port arg optional in docker compose port crazybolillo/compose
2 participants
@ndeloof @crazybolillo