feat: Add ability to add/remove servers #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cmrigney
requested changes
Nov 10, 2025
Contributor
cmrigney
left a comment
cmrigney
left a comment
There was a problem hiding this comment.
Overall looking good, just think we need to make those changes to remove
bobbyhouse
force-pushed
the
add-remove-server-to-from-profile
branch
from
c2689f5 to
0eb8425
Compare
Add functionality to add and remove servers from a workingset. Can add/remove by OCI ref or registry URI.
bobbyhouse
force-pushed
the
add-remove-server-to-from-profile
branch
from
0eb8425 to
2790b2b
Compare
- removed argument validation from working set command line parsing logic - change removal arguments from `--server` to `--name` - removed `EnsuresnapshotsResolved` logic as part of adding a server - update tests to use `Snapshot.Server.Name` - update tests to remove registry examples - added validation method to check for server name uniqueness
cmrigney
approved these changes
Nov 10, 2025
| return workingSet.validateUniqueServerNames() | ||
| } | ||
|
|
||
| func (workingSet *WorkingSet) validateUniqueServerNames() error { |
Contributor
There was a problem hiding this comment.
praise: Thanks for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added commands to add and remove servers from a working set.
docker mcp workingset server add [working-set-id] --server [ref or uri]Example
docker mcp workingset server add test-set --server docker://roberthouse224/mcp-dice:latest --server https://mcp.docker.com/v0/servers/slackdocker mcp workingset server remove [working-set-id] --server [ref or uri]Example
docker mcp workingset server remove test-set --server docker://roberthouse224/mcp-dice:latest --server https://mcp.docker.com/v0/servers/slack/versions/latestRelated issue
(very mandatory) A picture of a cute animal, if possible in relation to what you did
