Add support for identifierFieldNames option

Author: GromNaN

src/Validator/Constraints/Unique.php

@@ -7,6 +7,12 @@
 use Attribute;
 use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity;
 
+use function array_combine;
+use function array_filter;
+use function array_slice;
+use function func_get_args;
+use function func_num_args;
+
 /**
  * Constraint for the unique document validator
  *
@@ -23,28 +29,26 @@ class Unique extends UniqueEntity
     public function __construct(
         array|string $fields,
         ?string $message = null,
-        string $service = 'doctrine_odm.mongodb.unique',
+        ?string $service = null,
         ?string $em = null,
         ?string $entityClass = null,
         ?string $repositoryMethod = null,
         ?string $errorPath = null,
         bool|array|string|null $ignoreNull = null,
+        ?array $identifierFieldNames = null,
         ?array $groups = null,
         mixed $payload = null,
         array $options = [],
     ) {
-        parent::__construct(
-            fields: $fields,
-            message: $message,
-            service: $service,
-            em: $em,
-            entityClass: $entityClass,
-            repositoryMethod: $repositoryMethod,
-            errorPath: $errorPath,
-            ignoreNull: $ignoreNull,
-            groups: $groups,
-            payload: $payload,
-            options: $options,
+        // Call the parent constructor using named arguments
+        // symfony/doctrine-bridge 7.3 added the parameter $identifierFieldNames
+        $args              = array_combine(
+            array_slice(['fields', 'message', 'service', 'em', 'entityClass', 'repositoryMethod', 'errorPath', 'ignoreNull', 'identifierFieldNames', 'groups', 'payload', 'options'], 0, func_num_args()),
+            func_get_args(),
         );
+        $args              = array_filter($args, static fn ($v) => $v !== null);
+        $args['service'] ??= 'doctrine_odm.mongodb.unique';
+
+        parent::__construct(...$args);
     }
 }

tests/Validator/Constraints/UniqueTest.php

@@ -4,6 +4,8 @@
 
 namespace Doctrine\Bundle\MongoDBBundle\Tests\Validator\Constraints;
 
+use Composer\InstalledVersions;
+use Composer\Semver\VersionParser;
 use Doctrine\Bundle\MongoDBBundle\Validator\Constraints\Unique;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\Mapping\ClassMetadata;
@@ -23,6 +25,45 @@ public function testWithDefaultProperty(): void
         self::assertInstanceOf(Unique::class, $constraint);
         self::assertSame(['email'], $constraint->fields);
         self::assertSame('doctrine_odm.mongodb.unique', $constraint->validatedBy());
+        self::assertNull($constraint->em);
+    }
+
+    public function testWithGroups(): void
+    {
+        $metadata = new ClassMetadata(UniqueDocumentWithGroups::class);
+
+        $loader = new AttributeLoader();
+        self::assertTrue($loader->loadClassMetadata($metadata));
+
+        [$constraint] = $metadata->getConstraints();
+        self::assertInstanceOf(Unique::class, $constraint);
+        self::assertSame(['email'], (array) $constraint->fields);
+        self::assertSame(['group1'], $constraint->groups);
+        self::assertSame('doctrine_odm.mongodb.unique', $constraint->validatedBy());
+        self::assertNull($constraint->em);
+    }
+
+    public function testWithIdentifierFieldNames(): void
+    {
+        if (! InstalledVersions::satisfies(new VersionParser(), 'symfony/doctrine-bridge', '>= 7.3')) {
+            self::markTestSkipped('Requires symfony/doctrine-bridge 7.3 or higher, with $identifierFieldNames field');
+        }
+
+        $metadata = new ClassMetadata(UniqueDocumentWithIdentifierFieldNames::class);
+
+        $loader = new AttributeLoader();
+
+        self::assertTrue($loader->loadClassMetadata($metadata));
+
+        [$constraint] = $metadata->getConstraints();
+        self::assertInstanceOf(Unique::class, $constraint);
+        self::assertSame(['email'], $constraint->fields);
+        self::assertSame('Custom message', $constraint->message);
+        self::assertSame('custom_em', $constraint->em);
+        self::assertFalse($constraint->ignoreNull);
+        self::assertSame(['id', 'name'], $constraint->identifierFieldNames);
+        self::assertSame(['group1', 'group2'], $constraint->groups);
+        self::assertSame('doctrine_odm.mongodb.unique', $constraint->validatedBy());
     }
 }
 
@@ -31,3 +72,24 @@ class UniqueDocumentDummyOne
 {
     private string $email;
 }
+
+#[Unique(fields: 'email', groups: ['group1'])]
+class UniqueDocumentWithGroups
+{
+    private string $email;
+}
+
+#[Unique(
+    ['email'],
+    'Custom message',
+    em: 'custom_em',
+    ignoreNull: false,
+    identifierFieldNames: ['id', 'name'],
+    groups: ['group1', 'group2'],
+)]
+class UniqueDocumentWithIdentifierFieldNames
+{
+    private string $name;
+
+    private string $email;
+}