Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support psr/container 2 #747

Open
wants to merge 1 commit into
base: 7.0.x
Choose a base branch
from

Conversation

pascalheidmann
Copy link

psr/container 1 and 2 are basically the same but with type hints/return types

@driehle
Copy link
Member

driehle commented Nov 16, 2023

LGTM, but we'll first need to the same for DoctrineModule, otherwise this won't help. Would you mind providing a PR there as well?

@driehle driehle added this to the 6.1.0 milestone Nov 16, 2023
@driehle driehle added the Enhacement New feature or request label Nov 16, 2023
@snapshotpl
Copy link
Contributor

Every run in actions install v1 because doesn't meet dependecy requirements (e.g. laminas-servicemanager)

@TomHAnderson
Copy link
Member

DoctrineModule PR doctrine/DoctrineModule#829

@SenseException
Copy link
Member

I haven't checked every Continuous Integration build, just one lowest and one highest, but psr/container 1 is currently the only used version.

@driehle driehle modified the milestones: 6.1.0, 7.0.0 Jan 20, 2024
Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make any sense to support psr/container 2 unless we upgrade laminas-servicemanager to 4.0, as 3.x supports psr/container 1 only. For that, however, we will need to go into a new major release. I have changed the milestone accordingly.

Let's wait for laminas-servicemanager 4.0 to be published. An RC is available already.

@TomHAnderson TomHAnderson self-assigned this Mar 4, 2024
@TomHAnderson TomHAnderson linked an issue Mar 4, 2024 that may be closed by this pull request
@TomHAnderson TomHAnderson changed the base branch from 6.1.x to 7.0.x March 4, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhacement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orm3 compatibility
5 participants