-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support psr/container 2 #747
base: 7.0.x
Are you sure you want to change the base?
Conversation
LGTM, but we'll first need to the same for DoctrineModule, otherwise this won't help. Would you mind providing a PR there as well? |
Every run in actions install v1 because doesn't meet dependecy requirements (e.g. laminas-servicemanager) |
DoctrineModule PR doctrine/DoctrineModule#829 |
I haven't checked every Continuous Integration build, just one lowest and one highest, but psr/container 1 is currently the only used version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make any sense to support psr/container 2 unless we upgrade laminas-servicemanager to 4.0, as 3.x supports psr/container 1 only. For that, however, we will need to go into a new major release. I have changed the milestone accordingly.
Let's wait for laminas-servicemanager 4.0 to be published. An RC is available already.
psr/container
1 and 2 are basically the same but with type hints/return types