Regression MongoDB Purger with the new purge mode

[GromNaN]

Any chance this could be released? I cannot figure out how to load my MongoDB test fixtures without --purge-with-delete when using doctrine/data-fixtures:2.1.0.

Any chance this could be released? I cannot figure out how to load my MongoDB test fixtures without --purge-with-delete when using doctrine/data-fixtures:2.1.0.

$ php bin/console --env=test doctrine:mongodb:fixtures:load --no-interaction
  > purging database
In CreateCollection.php line 207:
                                                         
  Collection already exists. NS: mongo_test.events  
                                                         
doctrine:mongodb:fixtures:load [--group GROUP] [--append] [--dm DM]

Originally posted by @mickverm in doctrine/DoctrineMongoDBBundle#906 (comment)

[GromNaN]

@mickverm I understand that you are experiencing a new bug when you update doctrine/data-fixtures from 2.0 to 2.1, due to #544.

We added a call to $schemaManager->createCollections(). You did not share the exception backtrace, but I think the error comes from this line. Since we call $this->dm->getDocumentCollection($metadata->name)->drop() in the loop before, I don't get why the collection still exists.
Can you check why the collection mongo_test.events is not dropped?

[mickverm]

Here's the stack trace, I'll try to figure out why the collection still exists.

composer test:setup:mongo -- -vvv
  > purging database

In CreateCollection.php line 207:
                                                         
  [MongoDB\Driver\Exception\CommandException (48)]       
  Collection already exists. NS: mongo_test.events  
                                                         

Exception trace:
  at C:\<redacted>\vendor\mongodb\mongodb\src\Operation\CreateCollection.php:207
 MongoDB\Driver\Server->executeWriteCommand() at C:\<redacted>\vendor\mongodb\mongodb\src\Operation\CreateCollection.php:207
 MongoDB\Operation\CreateCollection->execute() at C:\<redacted>\vendor\mongodb\mongodb\src\Database.php:293
 MongoDB\Database->createCollection() at C:\<redacted>\vendor\doctrine\mongodb-odm\lib\Doctrine\ODM\MongoDB\SchemaManager.php:646
 Doctrine\ODM\MongoDB\SchemaManager->createDocumentCollection() at C:\<redacted>\vendor\doctrine\mongodb-odm\lib\Doctrine\ODM\MongoDB\SchemaManager.php:566
 Doctrine\ODM\MongoDB\SchemaManager->createCollections() at C:\<redacted>\vendor\doctrine\data-fixtures\src\Purger\MongoDBPurger.php:88
 Doctrine\Common\DataFixtures\Purger\MongoDBPurger->purgeWithDrop() at C:\<redacted>\vendor\doctrine\data-fixtures\src\Purger\MongoDBPurger.php:60
 Doctrine\Common\DataFixtures\Purger\MongoDBPurger->purge() at C:\<redacted>\vendor\doctrine\data-fixtures\src\Executor\AbstractExecutor.php:106
 Doctrine\Common\DataFixtures\Executor\AbstractExecutor->purge() at C:\<redacted>\vendor\doctrine\data-fixtures\src\Executor\MongoDBExecutor.php:61
 Doctrine\Common\DataFixtures\Executor\MongoDBExecutor->execute() at C:\<redacted>\vendor\doctrine\mongodb-odm-bundle\src\Command\LoadDataFixturesDoctrineODMCommand.php:99
 Doctrine\Bundle\MongoDBBundle\Command\LoadDataFixturesDoctrineODMCommand->execute() at C:\<redacted>\vendor\symfony\console\Command\Command.php:318
 Symfony\Component\Console\Command\Command->run() at C:\<redacted>\vendor\symfony\console\Application.php:1092
 Symfony\Component\Console\Application->doRunCommand() at C:\<redacted>\vendor\symfony\framework-bundle\Console\Application.php:123
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at C:\<redacted>\vendor\symfony\console\Application.php:341
 Symfony\Component\Console\Application->doRun() at C:\<redacted>\vendor\symfony\framework-bundle\Console\Application.php:77
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at C:\<redacted>\vendor\symfony\console\Application.php:192
 Symfony\Component\Console\Application->run() at C:\<redacted>\vendor\symfony\runtime\Runner\Symfony\ConsoleApplicationRunner.php:49
 Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() at C:\<redacted>\vendor\autoload_runtime.php:29
 require_once() at C:\<redacted>\bin\console:15

doctrine:mongodb:fixtures:load [--group GROUP] [--append] [--dm DM]

Script php bin/console --ansi --env=test doctrine:mongodb:fixtures:load --no-interaction handling the test:setup:mongo event returned with error code 48

[mickverm]

For some reason it attempts to create the same collection multiple times, and I think the reason might be that my document contains a ODM\DiscriminatorMap.

Here a simplified example:

#[ODM\Document(collection: 'events')]
#[ODM\DiscriminatorField(value: '_t')]
#[ODM\DiscriminatorMap(value: [
    'EventA' => EventA::class,
    'EventB' => EventB::class,
    'EventC' => EventC::class,
])]
class Event {}

#[ODM\Document(collection: 'events')]
class EventA extends Event {}

When I add a breakpoint to the following code in Doctrine\ODM\MongoDB\SchemaManager, I can see that $documentName first contains App\Document\Event and then App\Document\EventA.

 $this->dm->getDocumentDatabase($documentName)->createCollection(
     $class->getCollection(),
     $this->getWriteOptions($maxTimeMs, $writeConcern, $options),
);

[mickverm]

I also think I found how I can fix it in our code, drop collection: 'events' from child classes, add #ODM\InheritanceType(value: 'SINGLE_COLLECTION')] to the parent.

#[ODM\Document(collection: 'events')]
#[ODM\DiscriminatorField(value: '_t')]
#[ODM\DiscriminatorMap(value: [
    'EventA' => EventA::class,
    'EventB' => EventB::class,
    'EventC' => EventC::class,
])]
#[ODM\InheritanceType(value: 'SINGLE_COLLECTION')]
class Event {}

#[ODM\Document]
class EventA extends Event {}

Which I found in the documentation here: https://www.doctrine-project.org/projects/doctrine-mongodb-odm/en/2.9/reference/inheritance-mapping.html

So I'm not sure any more that it's a regression, I think it's more of a coding error on my part?

[GromNaN]

I confirm that #[ODM\InheritanceType('SINGLE_COLLECTION')] was missing in your configuration. You tried to create 3 distinct collections with the same name.