Skip to content

Commit a509c9e

Browse files
committed
Fix php-version in the ci matrix and add doc for error code 59
1 parent b807b27 commit a509c9e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/atlas-ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ env:
1414
jobs:
1515
atlas-local:
1616
runs-on: "${{ matrix.os }}"
17-
name: "PHP/${{ matrix.php }} Symfony/${{ matrix.symfony }} Driver/${{ matrix.driver-version }} Proxy/${{ matrix.proxy }}"
17+
name: "PHP/${{ matrix.php-version }} Symfony/${{ matrix.symfony }} Driver/${{ matrix.driver-version }} Proxy/${{ matrix.proxy }}"
1818
strategy:
1919
fail-fast: false
2020
matrix:
2121
os:
2222
- "ubuntu-latest"
23-
php:
23+
php-version:
2424
- "8.2"
2525
- "8.3"
2626
- "8.4"
@@ -33,7 +33,7 @@ jobs:
3333
- "lazy-ghost"
3434
include:
3535
# Test with ProxyManager
36-
- php: "8.2"
36+
- php-version: "8.2"
3737
symfony: "stable"
3838
driver-version: "stable"
3939
proxy: "proxy-manager"

tests/Doctrine/ODM/MongoDB/Tests/BaseTestCase.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,9 @@ protected function createFailPoint(string $failCommand, bool $transient = false,
323323
]),
324324
);
325325
$this->disableFailPoints = true;
326-
} catch (CommandException $commandException) {
327-
if ($commandException->getCode() === 59) {
326+
} catch (CommandException $exception) {
327+
// no such command: 'configureFailPoint'
328+
if ($exception->getCode() === 59) {
328329
self::markTestSkipped('Test skipped because the server does not support fail points');
329330
}
330331
}

0 commit comments

Comments
 (0)