Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open note images are mispositioned in WordPress embeds #42

Closed
reefdog opened this issue Dec 8, 2015 · 1 comment
Closed

Open note images are mispositioned in WordPress embeds #42

reefdog opened this issue Dec 8, 2015 · 1 comment

Comments

@reefdog
Copy link
Contributor

reefdog commented Dec 8, 2015

  1. Install v0.3.4 of our WordPress plugin (documentcloud/wordpress-documentcloud@89576f5 or later)
  2. Embed a page with a note
  3. Open that note
  4. ❌ Note image is misaligned badly

Reason: WordPress's default theme has an img { max-width: 100%; } rule that breaks us.

Hate to do it, but until we're iframed, we'll have to play selector whack-a-mole.
@reefdog
Copy link
Contributor Author

reefdog commented Dec 8, 2015

Fixed in 156b9fc

@reefdog reefdog closed this as completed Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reefdog