config refactor #8618

macneale4 · 2024-12-02T19:16:29Z

No description provided.

coffeegoddd · 2024-12-03T01:14:53Z

comparing_percentages
100.000000 to 100.000000

version	result	total
`0846755`	ok	5937457

version	total_tests
`0846755`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-17T02:01:08Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`6d9d278`	ok	5937457

version	total_tests
`6d9d278`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-17T20:48:09Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`c172912`	ok	5937457

version	total_tests
`c172912`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-18T01:24:10Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`2cc23e8`	ok	5937457

version	total_tests
`2cc23e8`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-18T01:32:39Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`63770b4`	ok	5937457

version	total_tests
`63770b4`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-18T23:23:11Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`4b428c4`	ok	5937457

version	total_tests
`4b428c4`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-20T00:17:55Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`6a214d0`	ok	5937457

version	total_tests
`6a214d0`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-23T20:55:30Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`6d01ec2`	ok	5937457

version	total_tests
`6d01ec2`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-23T23:48:12Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`97bf503`	ok	5937457

version	total_tests
`97bf503`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-24T00:33:06Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`c8e244c`	ok	5937457

version	total_tests
`c8e244c`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-24T00:42:36Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`f246492`	ok	5937457

version	total_tests
`f246492`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-24T01:08:27Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`bab6b09`	ok	5937457

version	total_tests
`bab6b09`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-24T01:16:41Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`96dd050`	ok	5937457

version	total_tests
`96dd050`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-26T18:49:29Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`a398f9c`	ok	5937457

version	total_tests
`a398f9c`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-26T18:57:06Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`7fcd09e`	ok	5937457

version	total_tests
`7fcd09e`	5937457

correctness_percentage
100.0

…te.sh

coffeegoddd · 2024-12-26T23:21:37Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`86e812d`	ok	5937457

version	total_tests
`86e812d`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-26T23:29:53Z

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`8739fc9`	ok	5937457

version	total_tests
`8739fc9`	5937457

correctness_percentage
100.0

coffeegoddd · 2024-12-27T01:18:10Z

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
`1ce0ef8`	ok	5937457

version	total_tests
`1ce0ef8`	5937457

correctness_percentage
100.0

macneale4 · 2024-12-27T01:31:03Z

go/cmd/dolt/system_checks.go

+		tmpDirCreated = true
+
+	} else if !stat.IsDir() {
+		// Should the file exist?? If it does is it a problem? Is it a directory??


coffeegoddd added the correctness_approved label Dec 3, 2024

macneale4 force-pushed the macneale4/tmp-tmp branch from 0846755 to 6d9d278 Compare December 17, 2024 01:26

macneale4 force-pushed the macneale4/tmp-tmp branch from c172912 to 2cc23e8 Compare December 18, 2024 00:48

macneale4 force-pushed the macneale4/tmp-tmp branch from 63770b4 to 4b428c4 Compare December 18, 2024 22:48

macneale4 force-pushed the macneale4/tmp-tmp branch 5 times, most recently from e1d400f to 6d01ec2 Compare December 23, 2024 20:22

macneale4 force-pushed the macneale4/tmp-tmp branch 4 times, most recently from 61c17bd to 97bf503 Compare December 23, 2024 23:14

macneale4 force-pushed the macneale4/tmp-tmp branch 2 times, most recently from 45fb594 to c8e244c Compare December 23, 2024 23:59

macneale4 force-pushed the macneale4/tmp-tmp branch from f246492 to bab6b09 Compare December 24, 2024 00:35

macneale4 force-pushed the macneale4/tmp-tmp branch from 96dd050 to a398f9c Compare December 26, 2024 18:14

macneale4 force-pushed the macneale4/tmp-tmp branch from 7fcd09e to 86e812d Compare December 26, 2024 22:46

macneale4 and others added 15 commits December 26, 2024 15:10

First pass on forcing .dolt/tmp

3b394ec

dolt init working again

a0ceee4

Verify that datadir is passed through correctly in server.go

81775d3

Allow a 'tmp' directory during dolt init

b4f8b75

Handle terminations and status fully in the parse* method

a6b453a

[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…

f9da0b9

…te.sh

Fix several breaking profile tests

aac8f1c

Pass through dataDirOverride

64da8b5

Add the cwd to cliCtx and use it in server config resolution

e4bb304

Update temp if rename fails using the real datadir

0f7f352

rename to bootstrapConfig and document

ac3093f

Never use original args after parsed. Set to nil.

f8a8e15

Ensure --data-dir is only specified once

8b7f4e9

[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…

e30bf18

…te.sh

Clean up. rename, document

ce43c81

macneale4 added 2 commits December 26, 2024 16:04

make the argparse insert functionality a little more robust and test it

1b3c238

relative config file path from cwd bug

1ce0ef8

macneale4 force-pushed the macneale4/tmp-tmp branch from 8739fc9 to 1ce0ef8 Compare December 27, 2024 00:43

macneale4 commented Dec 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config refactor #8618

config refactor #8618

macneale4 commented Dec 2, 2024

coffeegoddd commented Dec 3, 2024

coffeegoddd commented Dec 17, 2024

coffeegoddd commented Dec 17, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 20, 2024

coffeegoddd commented Dec 23, 2024

coffeegoddd commented Dec 23, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 27, 2024

macneale4 Dec 27, 2024

config refactor #8618

Are you sure you want to change the base?

config refactor #8618

Conversation

macneale4 commented Dec 2, 2024

coffeegoddd commented Dec 3, 2024

coffeegoddd commented Dec 17, 2024

coffeegoddd commented Dec 17, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 18, 2024

coffeegoddd commented Dec 20, 2024

coffeegoddd commented Dec 23, 2024

coffeegoddd commented Dec 23, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 24, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 26, 2024

coffeegoddd commented Dec 27, 2024

macneale4 Dec 27, 2024

Choose a reason for hiding this comment