Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd nudging blocks all other keyboard shortcuts #503

Closed
mskelton opened this issue Aug 1, 2022 · 1 comment · Fixed by #504
Closed

Cmd nudging blocks all other keyboard shortcuts #503

mskelton opened this issue Aug 1, 2022 · 1 comment · Fixed by #504

Comments

@mskelton
Copy link
Contributor

mskelton commented Aug 1, 2022

When focusing the crop selection and using cmd+arrow to nudge by 100px, the crop area will become stuck such that when you attempt to tab out of the component it will not work and will continue to nudge the crop. My assumption is that it's related to stale state in the keysDown set. This also results in all keyboard shortcuts failing for the page except ones controlled by the browser.
@mskelton
Copy link
Contributor Author

mskelton commented Aug 2, 2022

Just realized I actually was the one who introduced the behavior that broke this 🙂

#388

@mskelton mskelton mentioned this issue Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix meta shortcuts mskelton/react-image-crop
1 participant
@mskelton