- Rename 'Ghost' to 'ScatteringVolume'

- Revert the Transparency Slider change
- Fix 'ExtendedTranslucency::MaterialModel::Disabled' in hlsli

Author: ArcEarth

features/Extended Translucency/Shaders/ExtendedTranslucency/ExtendedTranslucency.hlsli

@@ -6,8 +6,8 @@ namespace ExtendedTranslucency
 		static const uint RimLight = 1;
 		static const uint IsotropicFabric = 2;
 		static const uint AnisotropicFabric = 3;
-		static const uint ScatteringSphere = 4;
-		static const uint Disabled = 4;  // Any value >= 4
+		static const uint ScatteringVolume = 4;
+		static const uint Disabled = 5;  // Any value >= 5
 	}
 
 	bool IsValidMaterial(uint Material)
@@ -41,12 +41,10 @@ namespace ExtendedTranslucency
 		float a0 = 1 - sqrt(1.0 - alpha);
 		return a0 * (length(cross(v, t)) + length(cross(v, b))) / (abs(dot(v, n)) + 0.001) - a0 * a0;
 	}
-
-	float GetViewDependentAlphaScatteringSphere(float alpha, float3 view, float3 normal)
+	
+	float GetViewDependentAlphaScatteringVolume(float alpha, float3 view, float3 normal)
 	{
-		float3 theta = cross(view, normal);
-		float gamma = sqrt(1 - dot(theta, theta));
-		return 1.0 - pow(1.0 - alpha, gamma);
+		return 1.0 - pow(1.0 - alpha, dot(view, normal));
 	}
 
 	float SoftClamp(float alpha, float limit)

package/Shaders/Lighting.hlsl

@@ -3205,12 +3205,12 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
 
 	[branch] if (ExtendedTranslucency::IsValidMaterial(AlphaMaterialModel))
 	{
-		if (alpha >= 0.0156862754 && alpha < 1.0) {
+		if (alpha >= 0.0156862754 && alpha <= 1.0 - 0.0156862754) {
 			float originalAlpha = alpha;
 			alpha = saturate(alpha * (1.0 - AlphaMaterialReduction));
 			[branch] if (AlphaMaterialModel == ExtendedTranslucency::MaterialModel::AnisotropicFabric)
 			{
-#			if defined(SKINNED) || !defined(MODELSPACENORMALS)
+#			if !defined(MODELSPACENORMALS)
 				alpha = ExtendedTranslucency::GetViewDependentAlphaFabric2D(alpha, viewDirection, tbnTr);
 #			else
 				alpha = ExtendedTranslucency::GetViewDependentAlphaFabric1D(alpha, viewDirection, worldNormal.xyz);
@@ -3220,9 +3220,9 @@ PS_OUTPUT main(PS_INPUT input, bool frontFace : SV_IsFrontFace)
 			{
 				alpha = ExtendedTranslucency::GetViewDependentAlphaFabric1D(alpha, viewDirection, worldNormal.xyz);
 			}
-			else if (AlphaMaterialModel == ExtendedTranslucency::MaterialModel::ScatteringSphere)
+			else if (AlphaMaterialModel == ExtendedTranslucency::MaterialModel::ScatteringVolume)
 			{
-				alpha = ExtendedTranslucency::GetViewDependentAlphaScatteringSphere(alpha, viewDirection, worldNormal.xyz);
+				alpha = ExtendedTranslucency::GetViewDependentAlphaScatteringVolume(alpha, viewDirection, worldNormal.xyz);
 			}
 			else
 			{

src/Features/ExtendedTranslucency.cpp

@@ -89,7 +89,7 @@ void ExtendedTranslucency::DrawSettings()
 			"1 - Rim Edge",
 			"2 - Isotropic Fabric, Glass, ...",
 			"3 - Anisotropic Fabric",
-			"4 - Ghost",
+			"4 - Scattering Volume",
 		};
 
 		static constexpr int AlphaModeSize = static_cast<int>(std::size(AlphaModeNames));
@@ -100,12 +100,12 @@ void ExtendedTranslucency::DrawSettings()
 		}
 		if (auto _tt = Util::HoverTooltipWrapper()) {
 			ImGui::Text(
-				"Anisotropic transluency will make the surface more opaque when you view it parallel to the surface.\n"
-				"  - Disabled: No anisotropic transluency\n"
+				"Anisotropic transluency will adjust the opacity based on your view angle to the translucent surface.\n"
+				"  - Disabled: No anisotropic transluency, flat alpha.\n"
 				"  - Rim Edge: Naive rim light effect with no physics model, the edge of the geometry is always opaque even its full transparent.\n"
 				"  - Isotropic Fabric: Imaginary fabric weaved from threads in one direction, respect normal map, also works well for layer of glass panels.\n"
 				"  - Anisotropic Fabric: Common fabric weaved from tangent and birnormal direction, ignores normal map.\n"
-				"  - Ghost: A volumn of light scattering or absoring material, it fade the geometry out at its edge instead of strength them like other material.\n");
+				"  - Scattering Volume: A **volumn** (instead of a layer) of light scattering or absoring material, it fade the geometry out at its edge instead of strength them like other material.\n");
 		}
 		if (ImGui::Checkbox("Skinned Mesh Only", &SkinnedOnly)) {
 			changed = true;
@@ -114,7 +114,7 @@ void ExtendedTranslucency::DrawSettings()
 			ImGui::Text("Control if this effect should only apply to skinned mesh, check this option if your are seeing undesired effect on random objects.");
 		}
 
-		if (ImGui::SliderFloat("Transparency Increase", &settings.AlphaReduction, -1.f, 1.f)) {
+		if (ImGui::SliderFloat("Transparency Increase", &settings.AlphaReduction, 0, 1.f)) {
 			changed = true;
 		}
 		if (auto _tt = Util::HoverTooltipWrapper()) {
@@ -164,7 +164,7 @@ std::pair<std::string, std::vector<std::string>> ExtendedTranslucency::GetFeatur
 	return {
 		"Extended Translucency provides realistic rendering of thin fabric and other translucent materials.\n"
 		"This feature supports multiple material models for different types of translucent surfaces.",
-		{ "Multiple translucency material models (rim light, isotropic/anisotropic fabric)",
+		{ "Multiple translucency material models (rim edge, isotropic/anisotropic fabric, ghost)",
 			"Realistic fabric translucency with directional light transmission",
 			"Per-material override support via NIF extra data",
 			"Configurable transparency and softness controls",

src/Features/ExtendedTranslucency.h

@@ -32,7 +32,7 @@ struct ExtendedTranslucency final : Feature
 		RimLight = 1,           // Similar effect like rim light
 		IsotropicFabric = 2,    // 1D fabric model, respect normal map
 		AnisotropicFabric = 3,  // 2D fabric model alone tangent and binormal, ignores normal map
-		ScatteringSphere = 4,   // 2D fabric model alone tangent and binormal, ignores normal map
+		ScatteringVolume = 4,   // Fade out at the edge, models a ball of fog (light decays in exponential on distance)
 
 		DescriptorUseDefault = 0,  // In ExtraFeatureDescriptor, 0 means 'UseDefault' instead of 'Disabled'
 		DescriptorDisabled = 7,    // In ExtraFeatureDescriptor, value >= 5 means 'Disabled'