Move leading_comments and trailing_comments to Elixir

[josevalim]

Hi @doorgan,

Amazing work on sourceror! It has been a very powerful tool for the growth of the Elixir community. I am wondering if it makes sense to move the leading_comment and trailing_comments metadata to Elixir. In particular:

1. Add a include_comments option to string_to_quoted which attaches it to the relevant nodes
2. Change the formatter to look for comments in the metadata instead of a separate value

I believe this should simplify the handing of comments here. Do you think this is desirable?

Thank you!

[zachdaniel]

I'm in support of this. I personally believe that effectively all of sourceror should be part of the standard library, but baby steps 😅

[doorgan]

Hi Jose! I think that's a great idea. A few years ago I would have been a bit hesitant but now I think leading_comments and trailing_comments satisfies most of the use cases of the community. Having all that and the formatting be part of elixir instead of a third party library would be great!

[josevalim]

@doorgan do you want to take a stab at that? Or should we put it on our own todo list?

[doorgan]

@josevalim Sure! I'll start working on that