installer: auto-generate ProductId

- ensures MajorUpgrade
- prevents multiple installations

Author: dorssel

Installer/Installer.wixproj

@@ -26,17 +26,25 @@
     <OutputName>usbipd-win</OutputName>
     <DefineSolutionProperties>false</DefineSolutionProperties>
     <PublishDir>..\UsbIpServer\bin\publish</PublishDir>
+    <!--
+    This ensures that each x.y.z version has a different product, so every upgrade is a MajorUpgrade.
+    It also ensures that 2 builds of the same x.y.z version will never be installed simultaneously.
+    The alternative (WiX AllowSameVersionUpgrades) causes ICE61.
+    
+    The chance of a hash-collision is much smaller than the chance of forgetting to update ProductId manually.
+    -->
+    <ProductId>EA1D5623-E6A7-4E4A-9259-E397$(GitVersion_MajorMinorPatch.GetHashCode().ToString(X8))</ProductId>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x64' ">
     <OutputPath>bin\$(Configuration)\</OutputPath>
     <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath>
-    <DefineConstants>Debug;PublishDir=$(PublishDir);DriversDir=$(ProjectDir)..\Drivers</DefineConstants>
+    <DefineConstants>Debug;PublishDir=$(PublishDir);DriversDir=$(ProjectDir)..\Drivers;ProductId=$(ProductId)</DefineConstants>
     <Cultures>en-US</Cultures>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|x64' ">
     <OutputPath>bin\$(Configuration)\</OutputPath>
     <IntermediateOutputPath>obj\$(Configuration)\</IntermediateOutputPath>
-    <DefineConstants>PublishDir=$(PublishDir);DriversDir=$(ProjectDir)..\Drivers</DefineConstants>
+    <DefineConstants>PublishDir=$(PublishDir);DriversDir=$(ProjectDir)..\Drivers;ProductId=$(ProductId)</DefineConstants>
     <Cultures>en-US</Cultures>
   </PropertyGroup>
   <ItemGroup>

Installer/Product.wxs

@@ -18,7 +18,7 @@
 -->
 <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
     <Product
-        Id="*"
+        Id="$(var.ProductId)"
         Name="usbipd-win"
         Language="1033"
         Version="$(var.GitVersion_MajorMinorPatch)"
@@ -33,9 +33,15 @@
             <MediaTemplate EmbedCab="yes" CompressionLevel="high" />
         <?endif?>
 
+        <!--
+        We guarantee that two different x.y.z versions will have a different ProductId, so
+        everything is always a MajorUpgrade. MinorUpdates and Patches have many requirements
+        for Feature and Component changes, which we will no doubt forget about in the future.
+        This being a small product, a MajorUpgrade is a small price to pay to prevent any mishaps.
+        Since we strictly follow component rules, we use afterInstallExecute to speed things up a bit.
+        -->
         <MajorUpgrade
             Schedule="afterInstallExecute"
-            AllowSameVersionUpgrades="yes"
             DowngradeErrorMessage="A newer version of [ProductName] is already installed."
             />
 

UsbIpServer/UsbIpServer.csproj

@@ -41,7 +41,7 @@
     <Copyright>Copyright (C) $([System.DateTime]::UtcNow.ToString("yyyy"))  $(Company)</Copyright>
 
     <PublishProfile>Properties\PublishProfiles\InputForInstaller.pubxml</PublishProfile>
-  </PropertyGroup>
+</PropertyGroup>
 
   <ItemGroup>
     <Content Include="..\COPYING.md" Link="COPYING.md" CopyToOutputDirectory="PreserveNewest" />

usbipd-win.sln

@@ -8,8 +8,13 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{4DF1A44E-CAFC-4543-AB76-76239FBEDF03}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
+		.gitattributes = .gitattributes
+		.gitignore = .gitignore
 		CODE_OF_CONDUCT.md = CODE_OF_CONDUCT.md
+		COPYING.md = COPYING.md
 		GitVersion.yml = GitVersion.yml
+		README.md = README.md
+		SECURITY.md = SECURITY.md
 	EndProjectSection
 EndProject
 Project("{930C7802-8A8C-48F9-8165-68863BCCD9DD}") = "Installer", "Installer\Installer.wixproj", "{080EF94C-A8EC-4975-A697-BBF8C1A56055}"