chore: Replace StyleCop.Analyzer library to unstable version (#2796)

* chore: replace stylecop to unstable package

* chore: fix target-typed new statement spacing that raise SA1000 errors by stylecop

* fix: SA1141 value tuple error that raised by stylecop

Author: filzrev

build/common.props

@@ -65,8 +65,9 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
+    <PackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556">
       <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
   </ItemGroup>
 

src/BenchmarkDotNet.Diagnostics.Windows/JitStatsDiagnoser.cs

@@ -60,7 +60,7 @@ protected override void AttachToEvents(TraceEventSession session, BenchmarkCase
 
         private sealed class MethodsJittedDescriptor : IMetricDescriptor
         {
-            internal static readonly MethodsJittedDescriptor Instance = new ();
+            internal static readonly MethodsJittedDescriptor Instance = new();
 
             public string Id => nameof(MethodsJittedDescriptor);
             public string DisplayName => "Methods JITted";
@@ -75,7 +75,7 @@ private sealed class MethodsJittedDescriptor : IMetricDescriptor
 
         private sealed class MethodsTieredDescriptor : IMetricDescriptor
         {
-            internal static readonly MethodsTieredDescriptor Instance = new ();
+            internal static readonly MethodsTieredDescriptor Instance = new();
 
             public string Id => nameof(MethodsTieredDescriptor);
             public string DisplayName => "Methods Tiered";
@@ -90,7 +90,7 @@ private sealed class MethodsTieredDescriptor : IMetricDescriptor
 
         private sealed class JitAllocatedMemoryDescriptor : IMetricDescriptor
         {
-            internal static readonly JitAllocatedMemoryDescriptor Instance = new ();
+            internal static readonly JitAllocatedMemoryDescriptor Instance = new();
 
             public string Id => nameof(JitAllocatedMemoryDescriptor);
             public string DisplayName => "JIT allocated memory";

src/BenchmarkDotNet.TestAdapter/BenchmarkExecutor.cs

@@ -15,7 +15,7 @@ namespace BenchmarkDotNet.TestAdapter
     /// </summary>
     internal class BenchmarkExecutor
     {
-        private readonly CancellationTokenSource cts = new ();
+        private readonly CancellationTokenSource cts = new();
 
         /// <summary>
         /// Runs all the benchmarks in the given assembly, updating the TestExecutionRecorder as they get run.

src/BenchmarkDotNet.TestAdapter/Remoting/BenchmarkExecutorWrapper.cs

@@ -8,7 +8,7 @@ namespace BenchmarkDotNet.TestAdapter.Remoting
     /// </summary>
     internal class BenchmarkExecutorWrapper : MarshalByRefObject
     {
-        private readonly BenchmarkExecutor benchmarkExecutor = new ();
+        private readonly BenchmarkExecutor benchmarkExecutor = new();
 
         public void RunBenchmarks(string assemblyPath, TestExecutionRecorderWrapper recorder, HashSet<Guid>? benchmarkIds = null)
         {

src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs

@@ -25,9 +25,9 @@ internal class VsTestEventProcessor : EventProcessor
         private readonly Dictionary<Guid, TestCase> cases;
         private readonly TestExecutionRecorderWrapper recorder;
         private readonly CancellationToken cancellationToken;
-        private readonly Stopwatch runTimerStopwatch = new ();
-        private readonly Dictionary<Guid, TestResult> testResults = new ();
-        private readonly HashSet<Guid> sentTestResults = new ();
+        private readonly Stopwatch runTimerStopwatch = new();
+        private readonly Dictionary<Guid, TestResult> testResults = new();
+        private readonly HashSet<Guid> sentTestResults = new();
 
         public VsTestEventProcessor(
             List<TestCase> cases,

src/BenchmarkDotNet/Columns/StatisticalTestColumn.cs

@@ -15,9 +15,9 @@ public class StatisticalTestColumn(Threshold threshold, SignificanceLevel? signi
     {
         private static readonly SignificanceLevel DefaultSignificanceLevel = SignificanceLevel.P1E5;
 
-        public static StatisticalTestColumn CreateDefault() => new (new PercentValue(10).ToThreshold());
+        public static StatisticalTestColumn CreateDefault() => new(new PercentValue(10).ToThreshold());
 
-        public static StatisticalTestColumn Create(Threshold threshold, SignificanceLevel? significanceLevel = null) => new (threshold, significanceLevel);
+        public static StatisticalTestColumn Create(Threshold threshold, SignificanceLevel? significanceLevel = null) => new(threshold, significanceLevel);
 
         public static StatisticalTestColumn Create(string threshold, SignificanceLevel? significanceLevel = null)
         {

src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs

@@ -95,7 +95,7 @@ public static (bool isSuccess, IConfig config, CommandLineOptions options) Parse
 
         private static (bool Success, string[] ExpandedTokens) ExpandResponseFile(string[] args, ILogger logger)
         {
-            List<string> result = new ();
+            List<string> result = new();
             foreach (var arg in args)
             {
                 if (arg.StartsWith("@"))

src/BenchmarkDotNet/Detectors/Cpu/HardwareIntrinsics.cs

@@ -97,7 +97,7 @@ static IEnumerable<string> GetCurrentProcessInstructionSets(Platform platform)
 
         private static string GetShortAvx512Representation()
         {
-            StringBuilder avx512 = new ("AVX-512F");
+            StringBuilder avx512 = new("AVX-512F");
             if (IsX86Avx512CDSupported) avx512.Append("+CD");
             if (IsX86Avx512BWSupported) avx512.Append("+BW");
             if (IsX86Avx512DQSupported) avx512.Append("+DQ");

src/BenchmarkDotNet/Detectors/CpuDetector.cs

@@ -11,12 +11,12 @@ namespace BenchmarkDotNet.Detectors;
 
 public class CpuDetector(params ICpuDetector[] detectors) : ICpuDetector
 {
-    public static CpuDetector CrossPlatform => new (
+    public static CpuDetector CrossPlatform => new(
         new WindowsCpuDetector(),
         new LinuxCpuDetector(),
         new MacOsCpuDetector());
 
-    private static readonly Lazy<CpuInfo?> LazyCpu = new (() => CrossPlatform.Detect());
+    private static readonly Lazy<CpuInfo?> LazyCpu = new(() => CrossPlatform.Detect());
     public static CpuInfo? Cpu => LazyCpu.Value;
 
     public bool IsApplicable() => detectors.Any(loader => loader.IsApplicable());

src/BenchmarkDotNet/Detectors/OsDetector.cs

@@ -13,13 +13,13 @@ namespace BenchmarkDotNet.Detectors;
 
 public class OsDetector
 {
-    public static readonly OsDetector Instance = new ();
+    public static readonly OsDetector Instance = new();
     private OsDetector() { }
 
     internal static string ExecutableExtension => IsWindows() ? ".exe" : string.Empty;
     internal static string ScriptFileExtension => IsWindows() ? ".bat" : ".sh";
 
-    private readonly Lazy<OsInfo> os = new (ResolveOs);
+    private readonly Lazy<OsInfo> os = new(ResolveOs);
     public static OsInfo GetOs() => Instance.os.Value;
 
     private static OsInfo ResolveOs()