Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AndroidX.Media3.ExoPlayer] Removing MediaSourceFactory causes MediaSources not to inherit IMediaSourceFactory #954

Open
ArchangelWTF opened this issue Sep 4, 2024 · 1 comment · May be fixed by #956
Open

[AndroidX.Media3.ExoPlayer] Removing MediaSourceFactory causes MediaSources not to inherit IMediaSourceFactory #954

ArchangelWTF opened this issue Sep 4, 2024 · 1 comment · May be fixed by #956
Labels
missing-api Java types/members not available in binding

Comments

@ArchangelWTF
Copy link

ArchangelWTF commented Sep 4, 2024 •
edited
Loading

Android application type

Android for .NET (net6.0-android, etc.)

Affected platform version

VS 2022

Description

Your supposed to be able to set MediaSources in ExoPlayer, however this is currently not possible as no MediaSource inherits IMediaSourceFactory (Due to it being removed)

I've been hitting my head into a wall on this issue for quite some time with your bindings, yet when I try to replicate them in ExoPlayerXamarin I never get the issue error CS0101: The namespace 'AndroidX.Media3.ExoPlayer.Source' already co ntains a definition for 'MediaSourceFactory' [D:\Jesse\AndroidX\generated\androidx.media3.media3-exoplayer\androidx.med ia3.media3-exoplayer.csproj::TargetFramework=net8.0-android] which seems to make me believe something else in this project is causing it to fail.

Steps to Reproduce

Using SetMediaSourceFactory will not work on any of the MediaSources (As they dont inherit IMediaSourceFactory)

Build a new instance of ExoPlayer with ExoPlayerBuilder and try to use SetMediaSourceFactory to set a MediaSource.

Did you find any workaround?

No response

Relevant log output

No response
@ArchangelWTF
Copy link
Author

Found a fix for this, will PR it soon as well as some other changes to the media3 bindings

@ArchangelWTF ArchangelWTF linked a pull request Sep 5, 2024 that will close this issue
Open
@jpobst jpobst added the missing-api Java types/members not available in binding label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing-api Java types/members not available in binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Media3 bindings ArchangelWTF/AndroidX
2 participants
@jpobst @ArchangelWTF