-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eventing to test builder. #6682
Conversation
@mitchdenny should we think about adding a test that verifies that members added to |
Or we could look at making the test builder derive? |
Would be a bigger (breaking?) change to change inheritance wouldn't it? Open to it, just wondering if there's something more pragmatic for the shorter term. |
+1. Add a test with reflection over both. If the test builder is missing something from |
@mitchdenny are you planning to add a test as suggested, or log a follow-up issue? |
I'll add a test. |
2aee9d5
to
7394ebd
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
We missed this. It was added to the test builder we use for our internal tests, but not the public API that we ship. Quick fix.
Fixes #6681
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):Microsoft Reviewers: Open in CodeFlow