Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error adding log entry with no body #6725

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 19, 2024

Description

Fixes #6703

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK
Copy link
Member Author

JamesNK commented Nov 20, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish we had a protobuf generator with null annotations.

@JamesNK JamesNK merged commit 1d53994 into main Nov 21, 2024
9 checks passed
@JamesNK JamesNK deleted the jamesnk/fix-logenetry-body branch November 21, 2024 23:56
@JamesNK
Copy link
Member Author

JamesNK commented Nov 22, 2024

/backport to 9.0

Copy link
Contributor

Started backporting to 9.0: https://github.com/dotnet/aspire/actions/runs/11965737380

Copy link
Contributor

@JamesNK an error occurred while backporting to 9.0, please check the run log for details!

The process '/usr/bin/git' failed with exit code 1

@JamesNK
Copy link
Member Author

JamesNK commented Nov 22, 2024

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11965747913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException when log event is missing body
2 participants