Skip to content

Commit 9f01e34

Browse files
wtgodbemkArtakMSFT
authored andcommitted
Revert "Use the latest available jdk (#59788)" (#60143)
This reverts commit 28bad7a.
1 parent cd4533d commit 9f01e34

File tree

5 files changed

+5
-6
lines changed

5 files changed

+5
-6
lines changed

eng/scripts/InstallJdk.ps1

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ $installDir = "$repoRoot\.tools\jdk\win-x64\"
2222
$javacExe = "$installDir\bin\javac.exe"
2323
$tempDir = "$repoRoot\obj"
2424
if (-not $JdkVersion) {
25-
$JdkVersion = "11.0.24"
25+
$globalJson = Get-Content "$repoRoot\global.json" | ConvertFrom-Json
26+
$JdkVersion = $globalJson.'native-tools'.jdk
2627
}
2728

2829
if (Test-Path $javacExe) {

global.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"xcopy-msbuild": "17.8.5"
2525
},
2626
"native-tools": {
27-
"jdk": "latest"
27+
"jdk": "11.0.24"
2828
},
2929
"msbuild-sdks": {
3030
"Microsoft.DotNet.Arcade.Sdk": "10.0.0-beta.25076.1",

src/SignalR/clients/java/signalr/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ allprojects {
2222
version project.findProperty('packageVersion') ?: "99.99.99-dev"
2323

2424
java {
25-
sourceCompatibility = 1.9
25+
sourceCompatibility = 1.8
2626
}
2727

2828
repositories {

src/SignalR/clients/java/signalr/test/signalr.client.java.Tests.javaproj

-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
<!-- Installing Java on ARM will take some work -->
77
<SkipHelixArm>true</SkipHelixArm>
88
<SkipHelixAlpine>true</SkipHelixAlpine>
9-
<!-- Temporary while Mac machines get new JDK -->
10-
<SkipHelixQueues>OSX.13.Amd64.Open;$(SkipHelixQueues)</SkipHelixQueues>
119
<PublishDir>$(OutputPath)</PublishDir>
1210
<TestDependsOnJava>true</TestDependsOnJava>
1311
</PropertyGroup>

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/GsonHubProtocolTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ public void invocationBindingFailureWhenParsingLocalDateTimeWithoutAppropriateTy
444444
assertEquals(HubMessageType.INVOCATION_BINDING_FAILURE, message.getMessageType());
445445
InvocationBindingFailureMessage failureMessage = (InvocationBindingFailureMessage) messages.get(0);
446446

447-
assertEquals("com.google.gson.JsonSyntaxException", failureMessage.getException().getClass().getName());
447+
assertEquals("java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 41 path $.arguments[0]", failureMessage.getException().getMessage());
448448
}
449449

450450
@Test

0 commit comments

Comments
 (0)