-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Our tools should format messages to match GitHub's UI format #1125
Comments
Sounds good to me, thanks :) |
This was referenced Jun 24, 2024
BillWagner
added a commit
to BillWagner/csharpstandard
that referenced
this issue
Sep 19, 2024
Contributes to dotnet#1125 Replace the existing logging code with the utility class that writes to the console, and adds a status check record. Log failures as status checks, but status is only to the output console.
The only tool remaining to hook into this mechanism is the grammar validator. That might be able to do it using curl, but let's wait a bit until the next updates are in place. |
BillWagner
added a commit
that referenced
this issue
Oct 4, 2024
* Add status checks to the test runner Contributes to #1125 Replace the existing logging code with the utility class that writes to the console, and adds a status check record. Log failures as status checks, but status is only to the output console. * Update tools/Utilities/StatusCheckLogger.cs * Apply suggestions from code review * Feedback from code review A bit of refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should format the error output for the TOC / anchor generator, Word generator, and the test extractor so that they participate in the GitHub PR Review process as markdownlint lint does.
@jskeet I'll take this on in a combination of 3 PRs if you want.
The text was updated successfully, but these errors were encountered: