Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split analyzers and code fix providers into different assemblies (but same package) #35752

Open
roji opened this issue Mar 8, 2025 · 0 comments

Comments

@roji
Copy link
Member

roji commented Mar 8, 2025

We have both code fixes in analyzers in the same assembly, which is something that shouldn't be done (see RS1038); our first code fix was added in #30835, and the reference to Microsoft.CodeAnalysis.Workspaces was added in that PR (/cc @DoctorKrolic).

In #34637 we upgraded to Microsoft.CodeAnalysis 4.13.0, at which point RS1038 started getting reported - it is currently suppressed.

We need to do some build work to have separate projects/assemblies for analyzers and code fixes, but pack them together into the same Microsoft.EntityFramework.Analyzers nuget pacakge. Note dotnet/runtime#88701 which tracks the same for .NET interop analyzers/codefix.

@roji roji added this to the Backlog milestone Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant