Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous interface implementation accessibility when tuple deconstruction is used. #4161

Open
enricosada opened this issue Dec 22, 2017 · 2 comments · May be fixed by #18426
Open

Anonymous interface implementation accessibility when tuple deconstruction is used. #4161

enricosada opened this issue Dec 22, 2017 · 2 comments · May be fixed by #18426
Assignees
@edgarfgp
Labels
Area-Compiler-PatternMatching pattern compilation, active patterns, performance, codegen Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
Backlog

Comments

@enricosada
Copy link
Contributor

moved from fsharp/fsharp#802 by @FrankBro

by @FrankBro :

Anonymous interface implementation accessibility when tuple deconstruction is used

Repro steps

module private PM = 
    type PT = 
        abstract A : int
    let a = { new PT with member __.A = 1 } // ok
    let b, c = // PT is less accessible than PT * PT
        { new PT with member __.A = 1 }
        , { new PT with member __.A = 1 }
/home/runner/main.fs(5,9): error FS0410: The type 'PT' is less accessible than the value, member or type 'val patternInput : PM.PT * PM.PT' it is used in

/home/runner/main.fs(5,9): error FS0410: The type 'PT' is less accessible than the value, member or type 'val patternInput : PM.PT * PM.PT' it is used in

Expected behavior

Should work just like a does.

Actual behavior

Compile error

Known workarounds

Construct the tuple after implementing the anonymous interfaces

Related information

Repro'd here: https://repl.it/repls/FavorableDarkturquoiseGordonsetter
@enricosada enricosada mentioned this issue Dec 22, 2017
Closed
@dsyme dsyme added Bug Area-Compiler Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. labels Jan 9, 2018
@dsyme
Copy link
Contributor

dsyme commented Jan 9, 2018 •
edited
Loading

Agree this is a bug. The compiler generated patternInput is either internally considered public or is somehow otherwise triggering the check

@cartermp cartermp added this to the 16.0 milestone Aug 29, 2018
@cartermp cartermp modified the milestones: 16.0, 16.1 Feb 21, 2019
@cartermp cartermp modified the milestones: 16.1, 16.2 Apr 23, 2019
@cartermp cartermp modified the milestones: 16.2, Backlog Apr 30, 2019
@dsyme dsyme added Area-Compiler-PatternMatching pattern compilation, active patterns, performance, codegen and removed Area-Compiler labels Mar 31, 2022
@vzarytovskii vzarytovskii moved this to Not Planned in F# Compiler and Tooling Jun 17, 2022
@vzarytovskii vzarytovskii reopened this Jan 5, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in F# Compiler and Tooling Jan 5, 2024
@edgarfgp edgarfgp self-assigned this Apr 5, 2024
@edgarfgp
Copy link
Contributor

edgarfgp commented Aug 2, 2024

Reminder to self: check with —realsig+

@edgarfgp edgarfgp linked a pull request Mar 28, 2025 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgarfgp edgarfgp

Labels
Area-Compiler-PatternMatching pattern compilation, active patterns, performance, codegen Bug Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
6 participants
@enricosada @vzarytovskii @KevinRansom @cartermp @dsyme @edgarfgp