Skip to content

Tests: set test source for range debug printing #18879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2025
Merged

Tests: set test source for range debug printing #18879

merged 2 commits into from
Sep 18, 2025

Conversation

auduchinok
Copy link
Member

Fixes #18521. Also fixes broken debug printing due to ShortFileName was removed in #18699.

Screenshot 2025-09-02 at 16 51 50

@auduchinok auduchinok requested a review from a team as a code owner September 2, 2025 15:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@auduchinok auduchinok closed this Sep 3, 2025
@auduchinok auduchinok reopened this Sep 3, 2025
edgarfgp
edgarfgp approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@auduchinok
Copy link
Member Author

This is ready 🙂

@T-Gro T-Gro merged commit c4001e5 into dotnet:main Sep 18, 2025
38 checks passed
@auduchinok auduchinok deleted the parser-testSource2 branch September 18, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@edgarfgp edgarfgp edgarfgp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't see range text in FCS tests
3 participants
@auduchinok @edgarfgp @T-Gro