-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few bugs in BuildHat code implementation #2123
Comments
I'm not familiar with the BuildHat binding. Could you please expand a bit the problems you found? And of course, if you are willing to help with a PR fixing the issues, you would be more than welcome :) |
@jeansfish it's been a long time since I implemented this binding and I don't remember everything. Now, firmware may have change and some elements may have change as well from the specifications. Happy to help.
The only potential issue I see is for the 2 WeDo sensors before the color one. |
@Ellerbach Thanks for your amazing job. Yes, when I digging into it, as the BuildHat protocol defines, the button is not an active sensor and the color matrix is an active one. |
I did not have all the sensors to test but most of them, so indeed, some may not fully work as expected. We love PR ;-) So once you have everything working, please submit a PR! fork the repo first then create a branch in your repo, make all your changes, push on your repo and then make a PR. And the git magic will happen :-) |
The text was updated successfully, but these errors were encountered: